Add missing linux flags and one missing for windows #3245
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkulakowski
force-pushed
the
mkulakow/add_linux_build_flags
branch
from
b4352a3 to
67538c7
Compare
dtrawins
reviewed
Apr 29, 2025
| @@ -215,14 +215,6 @@ build:windows --host_copt=-DNOGDI | |||
| build:windows --copt=/Zc:preprocessor | |||
| build:windows --host_copt=/Zc:preprocessor | |||
|
|
|||
| # Misc build options we need for windows. | |||
There was a problem hiding this comment.
why they are not needed anymore? @rasapala why they were added earlier?
dtrawins
reviewed
Apr 29, 2025
| # ov::Tensor::data method call results in deprecated warning and we use it in multiple places | ||
| "-Wno-deprecated-declarations", | ||
| "-Werror", |
There was a problem hiding this comment.
did we run some performance test to confirm no impact on benchmarks?
michalkulakowski
force-pushed
the
mkulakow/add_linux_build_flags
branch
from
f619f89 to
ed97c5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
CVS-162118
🧪 Checklist
``