Steve's tokenizer changes #3297
Open
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was working through a demo where it said to run "pip install -U optimum[diffusers,openvino]". When I did that, I noticed that it downloaded: openvino_tokenizers-2025.1.0.0-py3-none-manylinux2014_x86_64.whl. However, the tokenizer is built and installed in the image by the Dockerfile. After more digging, I found that openvino's python module is not installed in the image. This patch installs the openvino-tokenizer python module in the image and uses a symlink to point to the tokenizer shared object to save space.
Only create the convert_tokenizer if python is enbled
dkalinowski
requested review from
dtrawins,
mzegla and
michalkulakowski
and removed request for
michalkulakowski
dtrawins
reviewed
May 19, 2025
| @@ -220,6 +220,17 @@ RUN git clone https://github.com/openvinotoolkit/openvino_tokenizers.git /openvi | |||
| WORKDIR /openvino_tokenizers/build | |||
| RUN cmake .. -DCMAKE_BUILD_TYPE=Release -DCMAKE_VERBOSE_MAKEFILE="${VERBOSE_LOGS}" && cmake --build . --parallel $JOBS ; cp /openvino_tokenizers/build/src/lib*.so /opt/intel/openvino/runtime/lib/intel64/ | |||
|
|
|||
| WORKDIR /openvino_tokenizers/ | |||
There was a problem hiding this comment.
shall we add it also to ubuntu dockerfile?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
Taken from PR #3274