Fix fuzz build #3506
Merged
Fix fuzz build #3506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzegla
reviewed
Jul 16, 2025
src/BUILD
Outdated
| @@ -134,6 +134,7 @@ cc_shared_library( | |||
| features = [], | |||
| roots = [ | |||
| "//src:ovms_lib", | |||
| "@llm_engine//:llm_engine", "@libgit2_engine//:libgit2_engine", | |||
There was a problem hiding this comment.
Why is it needed here now and was not needed before?
There was a problem hiding this comment.
With FUZZER_BUILD=1 we only build this target. The shared bazel library will not build nor add this dependencies so it will not be available in bazel-out directory.
dkalinowski
reviewed
Jul 23, 2025
| @@ -355,7 +355,9 @@ RUN if [ "$FUZZER_BUILD" == "0" ]; then bazel build ${CAPI_FLAGS} --jobs $JOBS / | |||
| COPY MakefileCapi /ovms/ | |||
| RUN if [ "$FUZZER_BUILD" == "0" ]; then CAPI_FLAGS=${CAPI_FLAGS} make -f MakefileCapi cpp && \ | |||
| CAPI_FLAGS=${CAPI_FLAGS} make -f MakefileCapi c; fi ; | |||
| RUN mkdir -p /ovms_release/lib/ ; find /ovms/bazel-out/k8-*/bin -iname 'libovms_shared.so' -exec cp -v {} /ovms_release/lib/ \; | |||
| RUN mkdir -p /ovms_release/lib/ ; find /ovms/bazel-out/k8-*/bin -iname 'libovms_shared.so' -exec cp -v {} /ovms_release/lib/ \; \ | |||
| find /ovms/bazel-out/k8-*/bin -iname 'libopenvino_genai.so*' -exec cp -v {} /ovms_release/lib/ \; \ | |||
There was a problem hiding this comment.
why genai? is it another issue?
There was a problem hiding this comment.
libopenvino_genai also missing in the dependencies.
mzegla
approved these changes
Jul 23, 2025
dkalinowski
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary
JIRA CVS-168977
Add libgit2.so to fuzz build dependency - libovms_shared.
🧪 Checklist
``