Fix closure with multiple escape sequence in JSON builder #3767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the JSON parser's handling of escape sequences, specifically when multiple consecutive backslashes precede a quote character. The fix correctly determines whether a quote is escaped by counting consecutive backslashes instead of just checking for a single preceding backslash.
- Replaced simple single-backslash check with proper consecutive backslash counting logic
- Added comprehensive test case to verify the fix handles multiple escape sequences correctly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/llm/io_processing/partial_json_builder.cpp | Implements proper escape sequence handling by counting consecutive backslashes |
| src/test/llm/output_parsers/partial_json_builder_test.cpp | Adds test case to verify correct parsing of JSON with multiple escape sequences |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mzegla
force-pushed
the
fix_partial_json_builder
branch
from
84ba24a to
09c8328
Compare
dkalinowski
approved these changes
Nov 5, 2025
atobiszei
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.