Updated to latest ACA-Py version for compatibility and improvements #159
Conversation
|
Thanks @parth5805 — much appreciated!! Can you please fix the lack of a DCO (DCO - Developer Certificate of Origin - https://github.com/apps/dco. To fix, see: https://github.com/src-d/guide/blob/master/developer-community/fix-DCO.md) on the commits? More info as well on the failed DCO checks above. @amanji — are you able to spend some time to review this PR? |
|
yes guys let me work on it. |
parth5805
force-pushed
the
sync-with-latest-acapy
branch
from
8c9ada5 to
397ac71
Compare
|
@amanji I did some modifications on the code (removed comments and console logs and also ran it through prettier) |
|
@swcurran I think I fixed the DCO. |
|
The DCO check is not running…not sure why. Perhaps make another commit to see if that triggers it? I looked at the 2 commits and one has DCO, but I don’t think the other does. Not sure what happens if we squash. The linting sure amped up the PR…142 files. Yikes. @amanji — what do you think? |
parth5805
force-pushed
the
sync-with-latest-acapy
branch
from
397ac71 to
df911c2
Compare
|
@swcurran I just reverted the last commit |
parth5805
force-pushed
the
sync-with-latest-acapy
branch
from
3e33a65 to
e246564
Compare
Signed-off-by: Parth Patel <parthpatel17591759@gmail.com>
Signed-off-by: Parth Patel <parthpatel17591759@gmail.com>
parth5805
force-pushed
the
sync-with-latest-acapy
branch
from
e246564 to
7428e8b
Compare
|
@swcurran now DCO is fixed |
|
@amanji — take a look. I didn’t try running it — vacation review :-). But looks good... |
|
Hey @amanji Any feedbacks on this PR? |
| @@ -30,13 +30,8 @@ public void ConfigureServices(IServiceCollection services) | |||
| services.AddServerSideBlazor(); | |||
| services.AddHttpClient<FCAgentService>(c => | |||
| { | |||
| var agentUrl = Environment.GetEnvironmentVariable("FABER_AGENT_HOST"); | |||
| var agentUrl = "host.docker.internal"; | |||
There was a problem hiding this comment.
Should this be a default value to fall-back to if FABER_AGENT_HOST is unset, rather than replacing things completely? It also looks like the variable name might have changed, in docker-compose.yaml it looks like it might be AGENT_HOST.
Sync with latest ACA-Py version & make demo work