Skip to content

Add multiple kid per key feature, kid removal and get by kid routes #3472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Add multiple kid per key feature, kid removal and get by kid routes #3472

wants to merge 22 commits into from

Conversation

PatStLouis
Copy link
Contributor

@PatStLouis PatStLouis commented Jan 27, 2025 •
edited
Loading

The goal of this PR is to enable assigning multiple kid to a keypair, and unbind them.

This serves 2 purposes:

  • Publish the same key in 2 different locations, such as a did:webvh and parallel did:web
  • Publish the same key in 2 different format, such as Multikey and JsonWebKey

@PatStLouis
add multiple kid per key feature, kid removal and get by kid routes
6d80bf3 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
linting
912f3b7 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis PatStLouis requested a review from jamshale January 27, 2025 20:03
@PatStLouis
remove default kid, conflict with did key
d8a3be8 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
comment unused import
01c8086 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
linting
a62e429 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
46.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

jamshale
jamshale reviewed Jan 27, 2025
View reviewed changes
jamshale
jamshale reviewed Jan 27, 2025
View reviewed changes
PatStLouis and others added 3 commits March 31, 2025 23:23
@PatStLouis
Merge branch 'openwallet-foundation:main' into enable-multiple-kid-pe…
216083c 
…r-keypair
@PatStLouis
add unit tests for new key operations
9636441 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
Merge branch 'enable-multiple-kid-per-keypair' of github.com:OpSecId/…
d7a53cb 
…aries-cloudagent-python into enable-multiple-kid-per-keypair
@PatStLouis PatStLouis marked this pull request as ready for review April 1, 2025 03:50
PatStLouis added 14 commits April 1, 2025 03:50
@PatStLouis
formatting
e3f7e85 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
fix routes and operations
4308a3b 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
format
7449041 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
fix missing kid
da502a2 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
fix assertion
20719f1 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
fix assertion
54a7a74 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
return kid when creating key
de02aa2 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
fix unit tests
e7a0e9e 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
match multikey when unbinding
44f0130 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
match multikey when unbinding
d71ac51 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
linting
6c7f7fe 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
fix unit tests
2449594 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
fix unit tests
c731db0 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@PatStLouis
fix unit tests
ff90b94 
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 1, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
73.3% Coverage on New Code (required ≥ 80%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamshale jamshale jamshale left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PatStLouis @jamshale