-
Notifications
You must be signed in to change notification settings - Fork 312
feat: adds else if
and else
conditional clauses
#699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: wdl-1.3
Are you sure you want to change the base?
Conversation
70ec19d
to
4cd725b
Compare
4cd725b
to
28286a9
Compare
I agree with this, though I'll admit my programming background bias. I find it more complicated to create two unconnected @geoffjentry said:
And I can point to at least one instance of this pattern in our |
@peterhuene and @cjllanwarne, there still may be some polishing needed on the text, but let me know how this reads generally. |
This change proposes extending conditional statements to include
else if
andelse
clauses.These types of clauses have been proposed many times on Slack and more formally in #268 and #697. Overall, the feedback seems positive, though concerns have been raised as to whether the cost of added complexity is worth it (see #697 for more details). I have made my case at the end of #697 that I feel it's actually removing mental burden/complexity to add these clauses into the language.
TODO:
Closes #268.
Before submitting this PR, please make sure:
README.md
or other documentation to account for these changes (when appropriate).CHANGELOG.md
describing the change and linking back to your pull request.CONTRIBUTING.md
document.