Skip to content

Conversation

vsmalladi
Copy link
Contributor

@vsmalladi vsmalladi commented Feb 12, 2025

Fix some tests in 1.2 that can be parsed by wdl_test

Close #707
Close #708
Close #701

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have updated the README.md or other documentation to account for these
    changes (when appropriate).
  • You have updated the CHANGELOG.md describing the change and linking back to your pull request.
  • You have read and agree to the CONTRIBUTING.md document.
  • You have added or updated relevant example WDL tests to the specification.
    • See the guide for more details.

@vsmalladi vsmalladi requested a review from jdidion February 12, 2025 22:32
@vsmalladi
Copy link
Contributor Author

Closes #702

@claymcleod claymcleod added the K-chore (Kind) Issues that are related to clean-up tasks. label Feb 13, 2025
@claymcleod
Copy link
Collaborator

Did you have a look at #670? Regardless, it would be better to merge this into wdl-1.2.1 so that they can be included in that release.

@claymcleod
Copy link
Collaborator

But everything looks good once you check off the checklist and change the base branch 👍🏼.

@vsmalladi vsmalladi requested a review from claymcleod February 13, 2025 18:47
@vsmalladi vsmalladi changed the base branch from wdl-1.2 to wdl-1.2.1 February 13, 2025 18:47
@vsmalladi
Copy link
Contributor Author

Did you have a look at #670? Regardless, it would be better to merge this into wdl-1.2.1 so that they can be included in that release.

Ya i did. This PR solves more syntax issues. I think that one is on accuracy of the tests.

@claymcleod claymcleod added K-chore (Kind) Issues that are related to clean-up tasks. Z-specification-change (Metadata) An issue or PR related to a specification change. and removed K-chore (Kind) Issues that are related to clean-up tasks. labels Feb 18, 2025
@claymcleod claymcleod added the S05-in-progress (State) A task that is in progress. label Feb 26, 2025
vsmalladi and others added 30 commits October 4, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
K-chore (Kind) Issues that are related to clean-up tasks. S05-in-progress (State) A task that is in progress. Z-specification-change (Metadata) An issue or PR related to a specification change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants