[base] Fix hierarchical duplicate IP validation #116#202
Open
Stoiicc wants to merge 1 commit intoopenwisp:masterfrom
Open
[base] Fix hierarchical duplicate IP validation #116#202Stoiicc wants to merge 1 commit intoopenwisp:masterfrom
Stoiicc wants to merge 1 commit intoopenwisp:masterfrom
Conversation
Updates AbstractIpAddress.clean() to check for duplicate IP addresses not only within the same subnet but also across any subnet that contains the IP (parent, or child). Added a corresponding test to ensure a ValidationError is raised when an IP exists in any related subnet. Fixes openwisp#116
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Reference to Existing Issue
Closes #116 .
Description of Changes
Previously, AbstractIpAddress.clean() only checked for duplicate IP addresses within the same subnet.
As discussed in issue #116, this allows invalid configurations where:
An IP exists in a child subnet, and
The same IP is created again in a parent subnet.
This PR introduces hierarchical subnet duplicate detection by:
Identifying all related subnets
A subnet is considered related if its network contains the IP being validated.
This includes:
If the same IP exists in any related subnet, a ValidationError is raised.