Skip to content

Conversation

pgleeson
Copy link
Member

@pgleeson pgleeson commented Jul 24, 2025

Testing changes to c++ with existing actions

Tested on Windows.
@pgleeson
Copy link
Member Author

@kant2002 Please have a look at this PR, which is now running GitHub actions tests. It seems some of your changes to the C++ are causing the tests to fail, e.g.

 /usr/include/CL/opencl.hpp:1456:1: error: ‘CL_DEVICE_QUEUE_ON_HOST_PROPERTIES’ was not declared in this scope; did you mean ‘CL_DEVICE_QUEUE_PROPERTIES’?

See https://github.com/openworm/sibernetic/actions/runs/16505333248/job/46674341944

@kant2002
Copy link

I know approximately what's going on. I would try to build on WSL in addition to Windows. Let's see how it look. Temporary I create #215 to check that functional code changes actually compile properly. They are useful by itself anyway. Once they land, may PR would be run automatically I assume and it would be easier for both of us, since I can catch this kind of errors myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants