Skip to content

Commit f7d8b13

Browse files
authored
Fix missing semicolon in trace_dbuf.h (#16281)
On fedora 40, on the 6.9.4 kernel (in updates-testing), assign_str expands to a "do {<stuff> } while(0)" loop. Without this semicolon, the while(0) is unterminated, causing a cascade of useless errors. With this semicolon, it compiles fine. It also compiles fine on 6.8.11 (the previous kernel). I have not tested earlier kernels than that, but at worst it should add a pointless semicolon. All other instances in the source tree are already terminated with semicolons. Signed-off-by: Daniel Berlin <dberlin@dberlin.org> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Tony Hutter <hutter2@llnl.gov>
1 parent 398e675 commit f7d8b13

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/os/linux/zfs/sys/trace_dbuf.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@
8080
snprintf(__get_str(msg), TRACE_DBUF_MSG_MAX, \
8181
DBUF_TP_PRINTK_FMT, DBUF_TP_PRINTK_ARGS); \
8282
} else { \
83-
__assign_str(os_spa, "NULL") \
83+
__assign_str(os_spa, "NULL"); \
8484
__entry->ds_object = 0; \
8585
__entry->db_object = 0; \
8686
__entry->db_level = 0; \

0 commit comments

Comments
 (0)