Skip to content

Conversation

@JeanBaptisteWATENBERG
Copy link

@JeanBaptisteWATENBERG JeanBaptisteWATENBERG commented Jan 23, 2020

This pull request add support for express-http-proxy ^1.6.0

Fixes #151

Copy link
Member

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help.

I presume this means dropping support for earlier express. Is that something we should do?

@jcchavezs
Copy link
Contributor

jcchavezs commented Jan 29, 2020

This is related to #151.

@JeanBaptisteWATENBERG
Copy link
Author

JeanBaptisteWATENBERG commented Jan 29, 2020

Hi,

Indeed this is related to this issue. I met the same issue and decided to update the version. I was not aware of this GitHub issue.
Generally speaking I think a reference table for versions could be enough.
However I might find some time in next days to try to make it compatible with < 1.0.0 version in the direction discussed in the issue if you want.

@jcchavezs
Copy link
Contributor

@JeanBaptisteWATENBERG do you mind to rebase?

@JeanBaptisteWATENBERG
Copy link
Author

rebase done

@FlagX
Copy link

FlagX commented Nov 29, 2022

Why is this not merged yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: decorateRequest is REMOVED

4 participants