Skip to content

Commit 1971fbb

Browse files
authored
fix: minikube setup does not use github token (#2874)
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
1 parent a6c34e5 commit 1971fbb

File tree

3 files changed

+13
-7
lines changed

3 files changed

+13
-7
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@ jobs:
1111
strategy:
1212
matrix:
1313
java: [ 17, 21, 24 ]
14-
kubernetes: [ '1.30.12', '1.31.8', '1.32.4','1.33.0' ]
14+
# Use the latest versions supported by minikube, otherwise GitHub it will
15+
# end up in a throttling requests from minikube and workflow will fail.
16+
# Minikube does such requests only if a version is not officially supported.
17+
kubernetes: [ '1.30.12', '1.31.8', '1.32.4','1.33.1' ]
1518
uses: ./.github/workflows/integration-tests.yml
1619
with:
1720
java-version: ${{ matrix.java }}

.github/workflows/e2e-test.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Integration and end to end tests which runs locally and deploys the Operator to a Kubernetes
22
# (Minikube) cluster and creates custom resources to verify the operator's functionality
3-
name: Integration & End to End tests
3+
name: End to End tests
44
on:
55
pull_request:
66
paths-ignore:
@@ -32,8 +32,11 @@ jobs:
3232
- name: Setup Minikube-Kubernetes
3333
uses: manusa/actions-setup-minikube@v2.14.0
3434
with:
35-
minikube version: v1.34.0
36-
kubernetes version: v1.33.0
35+
minikube version: v1.36.0
36+
# Use the latest versions supported by minikube, otherwise GitHub it will
37+
# end up in a throttling requests from minikube and workflow will fail.
38+
# Minikube does such requests only if a version is not officially supported.
39+
kubernetes version: v1.33.1
3740
github token: ${{ secrets.GITHUB_TOKEN }}
3841
driver: docker
3942

.github/workflows/integration-tests.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,10 @@ jobs:
4141
- name: Set up Minikube
4242
uses: manusa/actions-setup-minikube@v2.14.0
4343
with:
44-
minikube version: 'v1.34.0'
44+
minikube version: 'v1.36.0'
4545
kubernetes version: '${{ inputs.kube-version }}'
46-
driver: 'docker'
47-
github token: ${{ secrets.GITHUB_TOKEN }}
46+
github token: ${{ github.token }}
47+
4848
- name: "${{inputs.it-category}} integration tests (kube: ${{ inputs.kube-version }} / java: ${{ inputs.java-version }} / client: ${{ inputs.http-client }})"
4949
run: |
5050
if [ -z "${{inputs.it-category}}" ]; then

0 commit comments

Comments
 (0)