Skip to content

✨ Implement Boxcutter #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

thetechnick
Copy link
Contributor

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2025
Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 842037e
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6880ff68bb673600088eedd8
😎 Deploy Preview https://deploy-preview-1946--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment on lines +195 to +211
hasher.Reset()

printer := spew.ConfigState{
Indent: " ",
SortKeys: true,
DisableMethods: true,
SpewKeys: true,
}
if _, err := printer.Fprintf(hasher, "%#v", objectToWrite); err != nil {
panic(err)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an OLM-ism or a boxcutter-ism? I wonder if json.NewEncoder(hasher).Encode(objectToWrite) would be better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

openshift-ci bot commented May 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign grokspawn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2025
@perdasilva perdasilva force-pushed the poc-boxcutter branch 2 times, most recently from 1c23866 to dc66501 Compare July 15, 2025 11:12
@perdasilva perdasilva changed the title POC: Implement Boxcutter ✨ Implement Boxcutter Jul 15, 2025
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 43.83954% with 392 lines in your changes missing coverage. Please review.

Project coverage is 70.99%. Comparing base (5786e67) to head (4f39c38).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...controllers/clusterextensionrevision_controller.go 57.71% 113 Missing and 13 partials ⚠️
api/v1/zz_generated.deepcopy.go 0.00% 114 Missing ⚠️
cmd/operator-controller/main.go 24.44% 63 Missing and 5 partials ⚠️
...perator-controller/rukpak/util/testing/bundlefs.go 0.00% 42 Missing ⚠️
internal/operator-controller/applier/boxcutter.go 75.35% 23 Missing and 12 partials ⚠️
...troller/controllers/clusterextension_controller.go 30.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1946      +/-   ##
==========================================
- Coverage   73.60%   70.99%   -2.62%     
==========================================
  Files          78       82       +4     
  Lines        7260     7934     +674     
==========================================
+ Hits         5344     5633     +289     
- Misses       1566     1923     +357     
- Partials      350      378      +28     
Flag Coverage Δ
e2e 39.79% <3.81%> (-3.93%) ⬇️
experimental-e2e 51.33% <3.96%> (-5.06%) ⬇️
unit 57.44% <40.25%> (-1.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva perdasilva force-pushed the poc-boxcutter branch 6 times, most recently from 35cdf3b to 370bac6 Compare July 21, 2025 16:28
@perdasilva perdasilva force-pushed the poc-boxcutter branch 5 times, most recently from 1653e77 to 7365a5b Compare July 23, 2025 11:51
Per Goncalves da Silva added 2 commits July 23, 2025 14:01
…time libs

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Per Goncalves da Silva added 2 commits July 23, 2025 14:20
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva force-pushed the poc-boxcutter branch 2 times, most recently from c6710e0 to 4f39c38 Compare July 23, 2025 13:01
Per Goncalves da Silva added 6 commits July 23, 2025 17:26
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants