-
Notifications
You must be signed in to change notification settings - Fork 66
🌱 Refactor applier to use HelmChartLoader #2089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b55cca3
to
d14da9c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2089 +/- ##
==========================================
+ Coverage 73.49% 73.60% +0.10%
==========================================
Files 78 79 +1
Lines 7240 7254 +14
==========================================
+ Hits 5321 5339 +18
+ Misses 1567 1563 -4
Partials 352 352
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9698135
to
500fd25
Compare
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
500fd25
to
5588f6f
Compare
if imageutil.IsBundleSourceChart(bundleFS) { | ||
return BundleTypeHelm | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I know this PR is scoped to refactoring how the Helm applier gets it chart, so this is more of a follow-up we should cover....)
I don't think it makes sense for the shared/util/image
package to:
- Contain helpers that have nothing to do with OCI images (this helper reads a bundleFS to decide if it contains a chart or not; that's not related to images)
- Contain anything related to helm (or any other bundle format at all). I imagine that this library should continue evolving to be the generic framework for turning an OCI ref into an
fs.FS
, where the actual implementation of that functionality is provided to the library, not part of the library.
Description
Refactor how helm applier gets chart by adding an extra layer of abstraction to deal with multiple bundle/fs formats (i.e. helm and registry+v1) and move feature check to main.go
Reviewer Checklist