Skip to content

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Aug 26, 2025

Description

  • Adds the .spec.config stanza to the experimental ClusterExtension API as a discriminated union with a single type: "Inline"
  • Updates Single/OwnNamespace to take the watchNamespace configuration from .spec.config.inline
  • Updates the Single/OwnNamespace docs
  • The facility to configure the watchNamespace via annotation is left in temporarily in order to not disrupt downstream tests. Once they have been updated to use .spec.config, the annotation facility will be removed.

Example

apiVersion: olm.operatorframework.io/v1
kind: ClusterExtension
metadata:
  name: test
spec:
  namespace: test
  serviceAccount:
    name: test-installer
  config:
    configType: Inline
    inline:
      watchNamespace: some-namespace
  source:
    sourceType: Catalog
    catalog:
      packageName: test-operator

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2025
@perdasilva perdasilva changed the title Bundle config api ✨ Bundle config api Aug 26, 2025
Copy link

netlify bot commented Aug 26, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 6ebde89
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68b0043b17e8e2000889bcf7
😎 Deploy Preview https://deploy-preview-2163--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 81.08108% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.71%. Comparing base (3b5e6fb) to head (6ebde89).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
api/v1/zz_generated.deepcopy.go 61.11% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2163      +/-   ##
==========================================
+ Coverage   72.67%   72.71%   +0.04%     
==========================================
  Files          79       79              
  Lines        7340     7378      +38     
==========================================
+ Hits         5334     5365      +31     
- Misses       1659     1666       +7     
  Partials      347      347              
Flag Coverage Δ
e2e 44.14% <8.10%> (-0.12%) ⬇️
experimental-e2e 56.16% <51.35%> (+1.32%) ⬆️
unit 58.20% <51.35%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva perdasilva changed the title ✨ Bundle config api ✨ ClusterExtensionConfig API Aug 26, 2025
@perdasilva perdasilva force-pushed the bundle-config-api branch 2 times, most recently from 544b420 to 5dd6ee0 Compare August 26, 2025 14:29
@perdasilva perdasilva marked this pull request as ready for review August 26, 2025 14:31
@perdasilva perdasilva requested a review from a team as a code owner August 26, 2025 14:31
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2025
@openshift-ci openshift-ci bot requested review from anik120 and grokspawn August 26, 2025 14:31
@perdasilva perdasilva force-pushed the bundle-config-api branch 2 times, most recently from 5c921e0 to a78b3a5 Compare August 26, 2025 15:16
Per Goncalves da Silva added 3 commits August 26, 2025 18:15
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@joelanford
Copy link
Member

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2025
//
// config is optional. When not specified, the default configuration of the resolved bundle will be used.
//
// <opcon:experimental>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at that experimental tag...

@tmshort
Copy link
Contributor

tmshort commented Aug 26, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2025
@tmshort
Copy link
Contributor

tmshort commented Aug 26, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2025
@tmshort
Copy link
Contributor

tmshort commented Aug 26, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2025
Per Goncalves da Silva added 2 commits August 28, 2025 09:24
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2025
@perdasilva perdasilva removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2025
Copy link
Contributor

@anik120 anik120 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2025
Copy link

openshift-ci bot commented Aug 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anik120, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anik120 anik120 merged commit d95f426 into operator-framework:main Aug 28, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants