Skip to content

Conversation

myabc
Copy link
Contributor

@myabc myabc commented Sep 2, 2025

Ticket

https://community.openproject.org/wp/67157

What are you trying to accomplish?

Make Project Selector use "friendly" URLs - using the project identifier/slug rather than numeric (DB) id. This should make front-end generated paths more consistent with paths generated by Rails URL helpers.

Generates links that looks like:
https://community.openproject.org/projects/openproject/?jump=home

rather than:
https://community.openproject.org/projects/14/?jump=home

Screenshots

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@myabc myabc marked this pull request as ready for review September 3, 2025 07:37
Copy link

github-actions bot commented Sep 3, 2025

Caution

The provided work package version does not match the core version

Details:

Please make sure that:

  • The work package version OR your pull request target branch is correct

@myabc myabc added this to the 16.4.x milestone Sep 3, 2025
@@ -23,6 +23,7 @@ export const insertInList = (
id: project.id,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also considered setting id: project.identifier. I wasn't sure if we need both the numeric project.id and the project.identifier.

@myabc myabc force-pushed the fix/67157-project-selector-friendly-urls branch from 29f121e to 200a193 Compare September 3, 2025 07:57
@myabc myabc merged commit 6ab2ec2 into release/16.4 Sep 3, 2025
14 of 15 checks passed
@myabc myabc deleted the fix/67157-project-selector-friendly-urls branch September 3, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants