fix: 为同步接口添加空数据校验并优化角色更新错误信息

Author: eryajf

logic/dingtalk_logic.go

@@ -114,6 +114,11 @@ func (d DingTalkLogic) SyncDingTalkUsers(c *gin.Context, req any) (data any, rsp
 		common.Log.Errorf("SyncDingTalkUsers: %s", errMsg)
 		return nil, tools.NewOperationError(errors.New(errMsg))
 	}
+	if len(staffs) == 0 {
+		errMsg := "获取到的用户数量为0"
+		common.Log.Errorf("SyncDingTalkUsers: %s", errMsg)
+		return nil, tools.NewOperationError(errors.New(errMsg))
+	}
 	// 2.遍历用户，开始写入
 	for i, staff := range staffs {
 		// 入库

logic/feishu_logic.go

@@ -33,6 +33,11 @@ func (d *FeiShuLogic) SyncFeiShuDepts(c *gin.Context, req any) (data any, rspErr
 		common.Log.Errorf("SyncFeiShuDepts: %s", errMsg)
 		return nil, tools.NewOperationError(errors.New(errMsg))
 	}
+	if len(depts) == 0 {
+		errMsg := "获取到的部门数量为0"
+		common.Log.Errorf("SyncFeiShuDepts: %s", errMsg)
+		return nil, tools.NewOperationError(errors.New(errMsg))
+	}
 
 	// 2.将远程数据转换成树
 	deptTree := GroupListToTree(fmt.Sprintf("%s_0", config.Conf.FeiShu.Flag), depts)
@@ -110,6 +115,11 @@ func (d FeiShuLogic) SyncFeiShuUsers(c *gin.Context, req any) (data any, rspErro
 		common.Log.Errorf("SyncFeiShuUsers: %s", errMsg)
 		return nil, tools.NewOperationError(errors.New(errMsg))
 	}
+	if len(staffs) == 0 {
+		errMsg := "获取到的用户数量为0"
+		common.Log.Errorf("SyncFeiShuUsers: %s", errMsg)
+		return nil, tools.NewOperationError(errors.New(errMsg))
+	}
 	// 2.遍历用户，开始写入
 	for i, staff := range staffs {
 		// 入库

logic/openldap_logic.go

@@ -25,6 +25,11 @@ func (d *OpenLdapLogic) SyncOpenLdapDepts(c *gin.Context, req any) (data any, rs
 		common.Log.Errorf("SyncOpenLdapDepts: %s", errMsg)
 		return nil, tools.NewOperationError(errors.New(errMsg))
 	}
+	if len(depts) == 0 {
+		errMsg := "获取到的部门数量为0"
+		common.Log.Errorf("SyncOpenLdapDepts: %s", errMsg)
+		return nil, tools.NewOperationError(errors.New(errMsg))
+	}
 	groups := make([]*model.Group, 0)
 	for _, dept := range depts {
 		groups = append(groups, &model.Group{
@@ -120,6 +125,11 @@ func (d OpenLdapLogic) SyncOpenLdapUsers(c *gin.Context, req any) (data any, rsp
 		common.Log.Errorf("SyncOpenLdapUsers: %s", errMsg)
 		return nil, tools.NewOperationError(errors.New(errMsg))
 	}
+	if len(staffs) == 0 {
+		errMsg := "获取到的用户数量为0"
+		common.Log.Errorf("SyncOpenLdapUsers: %s", errMsg)
+		return nil, tools.NewOperationError(errors.New(errMsg))
+	}
 	// 2.遍历用户，开始写入
 	for i, staff := range staffs {
 		groupIds, err := isql.Group.DeptIdsToGroupIds(staff.DepartmentIds)

logic/role_logic.go

@@ -115,7 +115,7 @@ func (l RoleLogic) Update(c *gin.Context, req any) (data any, rspError any) {
 	// 根据path中的角色ID获取该角色信息
 	roles, _ := isql.Role.GetRolesByIds([]uint{r.ID})
 	if len(roles) == 0 {
-		return nil, tools.NewMySqlError(fmt.Errorf("获取角色信息失败: %s", err.Error()))
+		return nil, tools.NewMySqlError(fmt.Errorf("获取角色信息失败: 未找到对应角色"))
 	}
 
 	if minSort >= roles[0].Sort {

logic/wecom_logic.go

@@ -33,6 +33,11 @@ func (d *WeComLogic) SyncWeComDepts(c *gin.Context, req any) (data any, rspError
 		common.Log.Errorf("SyncWeComDepts: %s", errMsg)
 		return nil, tools.NewOperationError(errors.New(errMsg))
 	}
+	if len(depts) == 0 {
+		errMsg := "获取到的部门数量为0"
+		common.Log.Errorf("SyncWeComDepts: %s", errMsg)
+		return nil, tools.NewOperationError(errors.New(errMsg))
+	}
 
 	// 2.将远程数据转换成树
 	deptTree := GroupListToTree(fmt.Sprintf("%s_1", config.Conf.WeCom.Flag), depts)
@@ -110,6 +115,11 @@ func (d WeComLogic) SyncWeComUsers(c *gin.Context, req any) (data any, rspError
 		common.Log.Errorf("SyncWeComUsers: %s", errMsg)
 		return nil, tools.NewOperationError(errors.New(errMsg))
 	}
+	if len(staffs) == 0 {
+		errMsg := "获取到的用户数量为0"
+		common.Log.Errorf("SyncWeComUsers: %s", errMsg)
+		return nil, tools.NewOperationError(errors.New(errMsg))
+	}
 	// 2.遍历用户，开始写入
 	for i, staff := range staffs {
 		// 入库