Update default height calculation to bodyScroll (#20)

kafkahw · web-flow · commit b793a6ae6041 · 2018-03-22T15:48:12.000-05:00
* Update default height calculation to bodyScroll
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,9 @@
 Next Release
 -------------
+1.4.0
+------
 * Added trigger for frame unloading. #18
+* Updated default height calucaltion to bodyScroll.
 
 1.3.2
 ------
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "xfc",
-  "version": "1.3.2",
+  "version": "1.4.0",
   "description": "A Cross Frame Container that handles securely embedding web content into a 3rd party domain",
   "author": "Cerner Corporation",
   "license": "Apache-2.0",
diff --git a/src/lib/dimension.js b/src/lib/dimension.js
@@ -49,7 +49,7 @@ const getWidth = {
   min: () => Math.min(...getAllMeasures(getWidth)),
 };
 
-export function calculateHeight(calMethod = 'max') {
+export function calculateHeight(calMethod = 'bodyScroll') {
   if (!(calMethod in getHeight)) {
     logger.error(`'${calMethod}' is not a valid method name!`);
   }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "xfc",`
`3`		`- "version": "1.3.2",`
	`3`	`+ "version": "1.4.0",`
`4`	`4`	`"description": "A Cross Frame Container that handles securely embedding web content into a 3rd party domain",`
`5`	`5`	`"author": "Cerner Corporation",`
`6`	`6`	`"license": "Apache-2.0",`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ const getWidth = {`
`49`	`49`	`min: () => Math.min(...getAllMeasures(getWidth)),`
`50`	`50`	`};`
`51`	`51`
`52`		`-export function calculateHeight(calMethod = 'max') {`
	`52`	`+export function calculateHeight(calMethod = 'bodyScroll') {`
`53`	`53`	`if (!(calMethod in getHeight)) {`
`54`	`54`	logger.error(`'${calMethod}' is not a valid method name!`);
`55`	`55`	`}`