Skip to content

Commit 5a30807

Browse files
committed
[GR-55515] Disable JDK 21 support in Graal Compiler
PullRequest: graal/20406
2 parents 66b50d5 + fecc060 commit 5a30807

File tree

5 files changed

+14
-19
lines changed

5 files changed

+14
-19
lines changed

compiler/ci/ci_common/gate.jsonnet

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,6 @@
235235
# Style jobs need to stay on a JDK compatible with all the style
236236
# checking tools (SpotBugs, Checkstyle, Eclipse formatter etc).
237237
"gate-compiler-style-labsjdk-latest-linux-amd64": t("45:00"),
238-
"gate-compiler-build-labsjdk-21-linux-amd64": t("25:00"),
239238

240239
"gate-compiler-ctw-labsjdk-latest-linux-amd64": {},
241240
"gate-compiler-ctw-labsjdk-latest-windows-amd64": t("1:50:00"),
@@ -495,12 +494,6 @@
495494
JVMCI_VERSION_CHECK: "strict",
496495
},
497496
}],
498-
local jdk_21_version_check_builds = [self.make_build("21", "linux-amd64", "build", extra_tasks={build:: s.base("build"),}).build + galahad.exclude {
499-
environment+: {
500-
# Run the strict JVMCI version check, i.e., that JVMCIVersionCheck.JVMCI_MIN_VERSION matches the versions in common.json.
501-
JVMCI_VERSION_CHECK: "strict",
502-
},
503-
}],
504497

505498
# Builds run on only on linux-amd64-jdk-latestDebug
506499
local jdk_latestDebug_builds = [self.make_build("LatestDebug", os_arch, task).build
@@ -520,7 +513,6 @@
520513
all_zgc_builds +
521514
all_serialgc_builds +
522515
style_builds +
523-
jdk_21_version_check_builds +
524516
linux_amd64_jdk_latest_builds +
525517
jdk_latestDebug_builds,
526518

compiler/mx.compiler/mx_compiler.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,8 @@ def __str__(self):
168168
_jdk_jvmci_version = None
169169
_jdk_min_jvmci_version = None
170170

171-
if os.environ.get('JDK_VERSION_CHECK', None) != 'ignore' and jdk.javaCompliance < '21':
172-
mx.abort('Graal requires JDK21 or later, got ' + str(jdk) +
171+
if os.environ.get('JDK_VERSION_CHECK', None) != 'ignore' and jdk.javaCompliance < '25':
172+
mx.abort('Graal requires JDK 25 or later, got ' + str(jdk) +
173173
'. This check can be bypassed by setting env var JDK_VERSION_CHECK=ignore')
174174

175175
def _check_jvmci_version(jdk):

compiler/src/jdk.graal.compiler.test/src/jdk/graal/compiler/hotspot/test/JVMCIVersionCheckTest.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,10 @@ public class JVMCIVersionCheckTest extends GraalCompilerTest {
4848

4949
private static final String[] JDK_VERSIONS = {
5050
null,
51-
"21",
52-
"21+3",
53-
"21.0.1+3",
54-
"21-ea+11-790"
51+
"99",
52+
"99+3",
53+
"99.0.1+3",
54+
"99-ea+11-790"
5555
};
5656

5757
static final Map<String, String> PROPS;
@@ -124,7 +124,7 @@ private static Version getVersion(String jdkVersion, int major, int minor, int b
124124
public void test01() {
125125
String legacyPrefix = version.toString().startsWith("jvmci") ? "prefix-" : "";
126126
String javaVmVersion = legacyPrefix + version.toString() + "Suffix";
127-
String javaSpecVersion = "21";
127+
String javaSpecVersion = "99";
128128
var props = createTestProperties(javaSpecVersion, javaVmVersion, null);
129129
var jvmciMinVersions = Map.of(
130130
javaSpecVersion, Map.of(JVMCIVersionCheck.DEFAULT_VENDOR_ENTRY, minVersion));

compiler/src/jdk.graal.compiler/src/jdk/graal/compiler/hotspot/JVMCIVersionCheck.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,14 @@ public final class JVMCIVersionCheck {
5454
* default/fallback entry.
5555
*/
5656
private static final Map<String, Map<String, Version>> JVMCI_MIN_VERSIONS = Map.of(
57-
"21", Map.of(DEFAULT_VENDOR_ENTRY, createLegacyVersion(23, 1, 33)),
5857
"25", Map.of(
5958
"Oracle Corporation", createLabsJDKVersion("25+21", 1),
6059
DEFAULT_VENDOR_ENTRY, createLabsJDKVersion("25+21", 1)));
6160
private static final int NA = 0;
6261
/**
6362
* Minimum Java release supported by Graal.
6463
*/
65-
private static final int JAVA_MIN_RELEASE = 21;
64+
private static final int JAVA_MIN_RELEASE = 25;
6665

6766
/**
6867
* Convenience factory for the current version scheme that only uses the JDK version and the

espresso/ci/ci.jsonnet

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@
99
vm_guard_includes: [],
1010

1111
local espresso_compiler_stub_gate = common.eclipse + common.jdt + common.predicates(true, false, false) +
12-
common.espresso_gate(allow_warnings=false, tags='style,fullbuild', timelimit='35:00', name='gate-espresso-compiler-stub-style-jdk21-linux-amd64') + {
12+
# [GR-64739] move espresso JDK 21 gates to on demand
13+
# common.espresso_gate(allow_warnings=false, tags='style,fullbuild', timelimit='35:00', name='gate-espresso-compiler-stub-style-jdk21-linux-amd64') + {
14+
common.espresso_gate(allow_warnings=false, tags='style,fullbuild', timelimit='35:00', name='ondemand-espresso-compiler-stub-style-jdk21-linux-amd64') + {
1315
setup+: [
1416
['cd', "../espresso-compiler-stub"],
1517
],
@@ -21,7 +23,9 @@
2123
},
2224

2325
local _builds = common.builds + [
24-
common.jdk21_gate_linux_amd64 + espresso_compiler_stub_gate,
26+
# [GR-64739] move espresso JDK 21 gates to on demand
27+
# common.jdk21_gate_linux_amd64 + espresso_compiler_stub_gate,
28+
common.jdk21_on_demand_linux + espresso_compiler_stub_gate,
2529
// Benchmarks
2630
// AWFY peak perf. benchmarks
2731
common.jdk21_weekly_bench_linux + common.espresso_benchmark('jvm-ce-llvm', 'awfy:*' , extra_args=['--vm.Xmx1g', '--vm.Xms1g']) + {name: 'weekly-bench-espresso-jvm-ce-awfy-jdk21-linux-amd64'},

0 commit comments

Comments
 (0)