Bugfix/pdpdevtool 6490 cli proxy does not work behind oracle vpn#1032
Bugfix/pdpdevtool 6490 cli proxy does not work behind oracle vpn#1032carolnavarropereira wants to merge 4 commits into
Conversation
…-cli-proxy-does-not-work-behind-oracle-vpn
oracle-contributor-agreement
Bot
added
the
OCA Verified
| //Add proxy agent for production in order to work properly with vpn | ||
| requestOptions.agent = this._proxyService.getProxyAgent(); | ||
| } else { | ||
| //Add agent for insecure connections when connecting to runboxes |
There was a problem hiding this comment.
I would refrain from adding comments with internal data or confidential information.
| //Add proxy agent for production in order to work properly with vpn | |
| requestOptions.agent = this._proxyService.getProxyAgent(); | |
| } else { | |
| //Add agent for insecure connections when connecting to runboxes | |
| // Add a proxy agent to support restricted network environments (e.g: VPN) | |
| requestOptions.agent = this._proxyService.getProxyAgent(); | |
| } else { | |
| // Add an agent to support relaxed TLS settings (development environments) |
There was a problem hiding this comment.
This message was already there.
There was a problem hiding this comment.
Yes. But, still, my point remains and I would use this opportunity to fix it now
| /* | ||
| ** Copyright (c) 2024 Oracle and/or its affiliates. All rights reserved. | ||
| ** Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl. | ||
| */ |
There was a problem hiding this comment.
Copyright notice should point to 2026, 2024 is not right.
(We should probably find the culprit config_file and update that one, but this is very much outside the scope so obviously I won't enforce it).
| /* | ||
| ** Copyright (c) 2022 Oracle and/or its affiliates. All rights reserved. | ||
| ** Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl. | ||
| */ |
There was a problem hiding this comment.
Copyright notice should point to 2026, 2022 is not right.
(We should probably find the culprit config_file and update that one, but this is very much outside the scope so obviously I won't enforce it).
| }, | ||
| SUITECLOUD_PROXY_SERVICE: { | ||
| SUPPORTED_PROTOCOLS: ['http:', 'https:'], | ||
| REGEX_SYSTEM_URL : /^system\.netsuite\.com$/, |
There was a problem hiding this comment.
I'm not sure if you've noticed, but this REGEX is more restrictive that the one we've been using.
See ApplicationConstants.js, line 44:
DOMAIN: {
PRODUCTION: {
GENERIC_NETSUITE_DOMAIN: 'system.netsuite.com',
PRODUCTION_DOMAIN_REGEX: '^system\\.(\\w+\\.)*netsuite\\.com$',
...
}
}
So the old Regex would allow system.na1.netsuite.com but the new one wouldn't...
We should verify which is the one we want to use and then use the same value, right?
Probably David, Antonio or Ali can provide more context here. Let me know what do you think
2 participants
No description provided.