Fix typo and add tests to check for that scenario.

Author: anthony-tuininga

src/oracledb/impl/thin/pool.pyx

@@ -587,7 +587,7 @@ cdef class ThinPoolImpl(BaseThinPoolImpl):
                     request.conn_impl.ping()
                     request.conn_impl.set_call_timeout(0)
                 except exceptions.Error:
-                    request.conn_impl._protocol.disconnect()
+                    request.conn_impl._protocol._disconnect()
                     request.conn_impl = None
             else:
                 conn_impl = self._create_conn_impl(request.params)

tests/test_2400_pool.py

@@ -1066,6 +1066,26 @@ def test_2456(self):
         with self.assertRaisesFullCode("DPY-2064"):
             test_env.get_pool(min=3, max=2)
 
+    @unittest.skipIf(test_env.get_is_drcp(), "not supported with DRCP")
+    def test_2457(self):
+        "2457 - ping pooled connection on receiving dead connection error"
+        admin_conn = test_env.get_admin_connection()
+        pool = test_env.get_pool(min=1, max=1, ping_interval=0)
+
+        # kill connection in pool
+        with admin_conn.cursor() as admin_cursor:
+            with pool.acquire() as conn:
+                sid, serial = self.get_sid_serial(conn)
+                sql = f"alter system kill session '{sid},{serial}'"
+                admin_cursor.execute(sql)
+
+        # acquire connection which should succeed without failure
+        with pool.acquire() as conn:
+            with conn.cursor() as cursor:
+                cursor.execute("select user from dual")
+                (user,) = cursor.fetchone()
+                self.assertEqual(user, test_env.get_main_user().upper())
+
 
 if __name__ == "__main__":
     test_env.run_test_cases()

tests/test_5500_pool_async.py

@@ -634,6 +634,26 @@ async def test_5542(self):
         with self.assertRaisesFullCode("DPY-2064"):
             test_env.get_pool_async(min=3, max=2)
 
+    @unittest.skipIf(test_env.get_is_drcp(), "not supported with DRCP")
+    async def test_5543(self):
+        "5543 - ping pooled connection on receiving dead connection error"
+        admin_conn = await test_env.get_admin_connection_async()
+        pool = test_env.get_pool_async(min=1, max=1, ping_interval=0)
+
+        # kill connection in pool
+        with admin_conn.cursor() as admin_cursor:
+            async with pool.acquire() as conn:
+                sid, serial = await self.get_sid_serial(conn)
+                sql = f"alter system kill session '{sid},{serial}'"
+                await admin_cursor.execute(sql)
+
+        # acquire connection which should succeed without failure
+        async with pool.acquire() as conn:
+            with conn.cursor() as cursor:
+                await cursor.execute("select user from dual")
+                (user,) = await cursor.fetchone()
+                self.assertEqual(user, test_env.get_main_user().upper())
+
 
 if __name__ == "__main__":
     test_env.run_test_cases()