Register DeviceActivityRecorder on all net devices#161
Open
wolfd wants to merge 1 commit into
Open
Conversation
Some net devices previously had this component registered, but not all. This meant that the device I am using, Femto Mega, wasn't able to do the recovery step that uses `checkDeviceActivity` to figure out if it's still online. In my logs I would see something like this: ``` [05/19 23:18:16.198626][warning][994036][NetDeviceEnumerator.cpp:277] 1 net device removed: [05/19 23:18:16.198642][warning][994036][NetDeviceEnumerator.cpp:278] - Name: Femto Mega, PID: 0x0669, ... ... [05/19 23:18:16.388417][warning][994062][ObException.cpp:25] A recoverable_exception has occurred! - where: DeviceBase.cpp(330) - msg: Device is deactivated/disconnected! DeviceComponentId:0 - type: WRONG_API_CALL_SEQUENCE - status: 108 [05/19 23:18:16.440090][warning][994062][ObException.cpp:25] A recoverable_exception has occurred! - where: DeviceBase.cpp(330) - msg: Device is deactivated/disconnected! DeviceComponentId:0 - type: WRONG_API_CALL_SEQUENCE - status: 108 ... ``` This change registers `DeviceActivityRecorder` on all devices that list their connection type as "Ethernet", and removes the now unnecessary registrations in G330, LiDAR, and MS600.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some net devices previously had this component registered, but not all. This meant that the device I am using, Femto Mega, wasn't able to do the recovery step that uses
checkDeviceActivityto figure out if it's still online.In my logs I would see something like this:
This change registers
DeviceActivityRecorderon all devices that list their connection type as "Ethernet", and removes the now unnecessary registrations in G330, LiDAR, and MS600.