Skip to content

Conversation

@MeitarR
Copy link
Contributor

@MeitarR MeitarR commented Oct 31, 2025

Description

Added a new config fail_on_unmatched_commit for git.

Motivation and Context

solves #1284

How Has This Been Tested?

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MeitarR MeitarR mentioned this pull request Oct 31, 2025
1 task
@MeitarR MeitarR force-pushed the feat-fail-on-unmatched-commit branch from 5f273bd to b071051 Compare October 31, 2025 17:07
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.51%. Comparing base (1e80739) to head (cb831aa).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
git-cliff-core/src/changelog.rs 4.77% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1298      +/-   ##
==========================================
- Coverage   43.88%   43.51%   -0.36%     
==========================================
  Files          23       23              
  Lines        2220     2241      +21     
==========================================
+ Hits          974      975       +1     
- Misses       1246     1266      +20     
Flag Coverage Δ
unit-tests 43.51% <4.77%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@orhun
Copy link
Owner

orhun commented Nov 3, 2025

Nice, we should also add a test fixture for this

@MeitarR MeitarR force-pushed the feat-fail-on-unmatched-commit branch 2 times, most recently from aad6fda to 17fc3f8 Compare November 7, 2025 15:28
@MeitarR MeitarR marked this pull request as ready for review November 7, 2025 16:00
@MeitarR MeitarR requested a review from orhun as a code owner November 7, 2025 16:00
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall!

@MeitarR MeitarR force-pushed the feat-fail-on-unmatched-commit branch 4 times, most recently from f3592af to a120444 Compare November 14, 2025 20:55
@MeitarR MeitarR force-pushed the feat-fail-on-unmatched-commit branch 2 times, most recently from b4c0e96 to 97c5e63 Compare November 16, 2025 20:28
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only need to update the website about this new option :)

@MeitarR MeitarR force-pushed the feat-fail-on-unmatched-commit branch from 97c5e63 to 7e41a47 Compare November 23, 2025 21:02
@MeitarR
Copy link
Contributor Author

MeitarR commented Nov 23, 2025

Looks good, only need to update the website about this new option :)

Added in 7e41a47

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orhun orhun changed the title feat(changelog): Fail on unmatched commit if configured feat(changelog): support failing on unmatched commits Nov 24, 2025
@orhun orhun merged commit a22a1a3 into orhun:main Nov 24, 2025
92 of 93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants