blueprint: new customization: dnf.config #61
Conversation
mvo5
left a comment
mvo5
left a comment
There was a problem hiding this comment.
Thanks, this looks good. Just for my own understanding - oas/components/{dnf,_config}.yaml is the source and the rest is auto-generated with "make schema", correct?
Correct! |
|
@mvo5 more info in the README of the project @achilleas-k can you also update the |
|
I was wondering it it would be easier if auto-generate content would be their own commit (with just -m 'run make schema') but I'm probably (massively) overthinking this :) |
I always prefer the idea of having commits be consistent, but maybe we can reconsider that for this repo. |
New dnf.config customization block that enables one option for now: set_releasever. The option is meant to set the releasever dnf variable to the value of the distro's release version, which ties a system to a specific update of RHEL. This prevents a system from being updated to a later minor RHEL release through `dnf upgrade` and is the mechanism for keeping systems on extended support releases (EUS and E4S). The dnf customization block is created so that it might later be used for other variables (perhaps even arbitrary, user-defined variables). However, the releasever variable will be treated separately so that it can be a simple switch that sets the `releasever` value to the one for the image's distro dynamically. The config key `set_releasever` was chosen over `set_release_ver` because the variable name is `releasever` and it is more consistent with other user-facing use cases where it is treated as a single word.
achilleas-k
force-pushed
the
new-customization/dnf
branch
from
b1549bc to
67b087f
Compare
I am not sure what you mean actually by this. |
lzap
left a comment
lzap
left a comment
There was a problem hiding this comment.
This is good but convertors can be only implemented once BP is merged and upgraded. So let's wait with merging?
|
Setting to draft until the main blueprint change is merged so I can add some tests for the converter. |
|
I have two days left before my two-weeks vacation, this PR is okay, feel free to merge even without conversion make an issue for that. FYI convertor's error handling needs a refactoring that is happening in #60 |
|
Let's merge this then and add conversion later. |
|
Thank you! |
4 participants
New dnf.config customization block that enables one option for now: set_releasever. The option is meant to set the releasever dnf variable to the value of the distro's release version, which ties a system to a specific update of RHEL. This prevents a system from being updated to a later minor RHEL release through
dnf upgradeand is the mechanism for keeping systems on extended support releases (EUS and E4S).The dnf customization block is created so that it might later be used for other variables (perhaps even arbitrary, user-defined variables). However, the releasever variable will be treated separately so that it can be a simple switch that sets the
releasevervalue to the one for the image's distro dynamically.The config key
set_releaseverwas chosen overset_release_verbecause the variable name isreleaseverand it is more consistent with other user-facing use cases where it is treated as a single word.Counterpart to osbuild/blueprint#34