fix: ensure data is copied to kernel address space before convert VA to PA #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure-stars
reviewed
Jun 10, 2025
|
Can you solve the merge conflict and CI error? |
… convert VA to PA Underlying driver assumes a linear mapping between virtual address and physical address when converting them, which is only present in kernel address space. So under circumstance related to physical address, we should copy the buffer to kernel space. - `sys_write` will finally call `axfs::dev::Disk::write_one` in dev.rs, which will use the buffer directly. - read from stdin will finally call `console_read_bytes`， which will also use the buffer directly.
eternalcomet
force-pushed
the
fix-phys-addr-convert
branch
from
d9bea7a to
1ea06fb
Compare
done |
Azure-stars
approved these changes
Jun 16, 2025
AsakuraMizu
pushed a commit
that referenced
this pull request
Jul 7, 2025
… convert VA to PA (#52) Underlying driver assumes a linear mapping between virtual address and physical address when converting them, which is only present in kernel address space. So under circumstance related to physical address, we should copy the buffer to kernel space. - `sys_write` will finally call `axfs::dev::Disk::write_one` in dev.rs, which will use the buffer directly. - read from stdin will finally call `console_read_bytes`， which will also use the buffer directly.
AsakuraMizu
pushed a commit
that referenced
this pull request
Jul 7, 2025
… convert VA to PA (#52) Underlying driver assumes a linear mapping between virtual address and physical address when converting them, which is only present in kernel address space. So under circumstance related to physical address, we should copy the buffer to kernel space. - `sys_write` will finally call `axfs::dev::Disk::write_one` in dev.rs, which will use the buffer directly. - read from stdin will finally call `console_read_bytes`， which will also use the buffer directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Underlying driver assumes a linear mapping between virtual address and physical address when converting them, which is only present in kernel address space. So under circumstance related to physical address, we should copy the buffer to kernel space.
(cherry picked from commit 25abd28)
Related Issues(If necessary)
sys_writewill finally callaxfs::dev::Disk::write_onein dev.rs, which will use the buffer directly.console_read_bytes， which will also use the buffer directly.Implementation Details
Make sure that the buffer is in kernel address space so that there is a linear mapping between virtual address and physical address.