Skip to content

Conversation

AsakuraMizu
Copy link
Collaborator

This PR mainly adds support for args and envs for exec. Additionally, several issues closely related to exec have been fixed:

  1. Testcases should run in the same directory as the executable
  2. libc.so path should be absolute
  3. clone_task should set user heap base
  4. current_task.set_name should not reference data in the old user space
  5. MutexGuard<AddrSpace> should be dropped before entering user space

@Azure-stars
Copy link
Collaborator

If you can pass exec test case, please refer to readme to add it to testcases list for CI test.

You can submit changes after ensuring that the local test passes.

@AsakuraMizu
Copy link
Collaborator Author

If you can pass exec test case, please refer to readme to add it to testcases list for CI test.

You can submit changes after ensuring that the local test passes.

I could not pass the test as the test script doesn't handle line endings when comparing two strings. I think maybe we could improve the test script elsewhere and let this PR just focus on exec.

@Azure-stars
Copy link
Collaborator

If you can pass exec test case, please refer to readme to add it to testcases list for CI test.
You can submit changes after ensuring that the local test passes.

I could not pass the test as the test script doesn't handle line endings when comparing two strings. I think maybe we could improve the test script elsewhere and let this PR just focus on exec.

Fix it on 52b0ed9

@Azure-stars Azure-stars merged commit c39df40 into oscomp:main Mar 12, 2025
25 checks passed
@AsakuraMizu AsakuraMizu deleted the feat/exec-args-envs branch March 13, 2025 12:08
Ressed pushed a commit that referenced this pull request Mar 15, 2025
* feat: exec args & envs

* Enable basic/execve testcase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants