refactor: remove arceos_posix_api #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure-stars
reviewed
May 11, 2025
|
This PR will be merged after oscomp/arceos#38 |
I don't quite agree with this. It seems that there is still a long way to go to solve the problem of namespaces, and the issues here are more urgent. |
- organize handle_syscall - add (un)link - add geteuid, get(e)gid - add warning for pipe2
Co-authored-by: mivik <mivikq@gmail.com>
see oscomp/arceos#28 Co-authored-by: jhwang <jiahua-wang@outlook.com>
|
Hold on a second, i'm going to fix |
Azure-stars
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally, we can start solving this old issue (#16).
This PR is basically the same as #18, but cleaned up.
Content
arceos_posix_apiand integrate the code here.bindgengenerated type with linux_raw_sys.UserPtrrelated stuffs. (we have proved in actual development that this design is better, although there are still many problems, but now may not be too late to do a completely new design)handle_syscallcontent. Before this, the order of syscalls was completely chaotic.syscall_instrumentas it's now useless.link/unlink/geteuid/getgid/getegid) and especially handle some x86_64 specific issues.dup2should close old fdwritevshould ignore zero-length buffer (see fix ftello_unflushed_append arceos#28)stat-related stuffs but I cannot remember all of them 😢gettimeofdayshould usewall_time(see refactor: remove arceos_posix_api #47 (comment))openatcould not associate correct path with opened file or directory (see refactor: remove arceos_posix_api #47 (comment))getdents64progressKnown issues
getdents64has issues but I actually don't know how to fix it. I'm asking @eternalcomet to make a PR maybe.Since we no longer definetimespec,timevalorsockaddrourselves but using the definition from linux_raw_sys, we can't implement conversion traits (From<Duration>and etc) on it. So a set of conversion functions are added.FilePathis still ugly but I don't touch it. I'm hoping of path types fromaxfs-ng-vfs.