layerspecific additional whitlisted urlparams not found in caps #1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZakarFin
reviewed
Oct 30, 2024
| } | ||
|
|
||
| private String getLayerAdditionalRequestParams() { | ||
| String[] layerUrlParams = layer.getOskariLayer().getUrl().split("\\?"); |
There was a problem hiding this comment.
OskariLayer has getParams(). We should have the apikey there instead of parsing it from the URL. Also IOHelper has bunch of methods parsing and constructing URLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some layers require apikeys or referers or whatnot to function, and those did not get added in printservice.
This solution is based on paikkis and one provider specifically, so the whitelist probably should reside somewhere else than hardcoded here and in paikkis' case we might also consider a few other whitelisted params as well.