Skip to content

Linked place names need to include the default language #2714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lonvia opened this issue May 19, 2022 · 2 comments · May be fixed by #3728
Open

Linked place names need to include the default language #2714

lonvia opened this issue May 19, 2022 · 2 comments · May be fixed by #3728

Comments

@lonvia
Copy link
Member

lonvia commented May 19, 2022

If a place is linked to a boundary and has different names, these names are added to the boundary. However, Nominatim doesn't do the expansion to the default language of the country there.

Example: the boundary of Popayan gets linked to the town node. The boundary only has an ugly descriptive name while the node has the proper town name. English speakers get the _place_name:en while for Spanish speakers the name:es is preferred. From the _place_name, the additional _place_name:es (the default language of Colombia) needs to be inferred.

@lonvia
Copy link
Member Author

lonvia commented May 6, 2023

See

NEW.name := add_default_place_name(NEW.country_code, NEW.name);
to learn where local names are added. See
SELECT hstore(array_agg('_place_' || key), array_agg(value)) INTO extra_names
for where the place names from the linked place are linked in.

Note: if you want to pick this up as a 'good first issue', please start with creating a BDD test that reproduces the example from the issue and create a PR with the test (which should still be failing at this point). Start with the following test as a blueprint:

Scenario: Boundaries without names inherit names from linked places

asharmalik19 added a commit to asharmalik19/Nominatim that referenced this issue Mar 27, 2025
Add failing test for issue osm-search#2714 to verify default language expansion
asharmalik19 added a commit to asharmalik19/Nominatim that referenced this issue Mar 28, 2025
Add failing test for issue osm-search#2714 to verify default language expansion
asharmalik19 added a commit to asharmalik19/Nominatim that referenced this issue Apr 3, 2025
Add failing test for issue osm-search#2714 to verify default language expansion
@divyanshuagarwal-23

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants