-
-
Notifications
You must be signed in to change notification settings - Fork 750
Linked place names need to include the default language #2714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
See Nominatim/lib-sql/functions/placex_triggers.sql Line 1034 in 5751686
Note: if you want to pick this up as a 'good first issue', please start with creating a BDD test that reproduces the example from the issue and create a PR with the test (which should still be failing at this point). Start with the following test as a blueprint: Nominatim/test/bdd/db/import/linking.feature Line 294 in 157414a
|
Add failing test for issue osm-search#2714 to verify default language expansion
Add failing test for issue osm-search#2714 to verify default language expansion
Add failing test for issue osm-search#2714 to verify default language expansion
If a place is linked to a boundary and has different names, these names are added to the boundary. However, Nominatim doesn't do the expansion to the default language of the country there.
Example: the boundary of Popayan gets linked to the town node. The boundary only has an ugly descriptive name while the node has the proper town name. English speakers get the
_place_name:en
while for Spanish speakers thename:es
is preferred. From the_place_name
, the additional_place_name:es
(the default language of Colombia) needs to be inferred.The text was updated successfully, but these errors were encountered: