Linked place names to Default language

[tarhsandrasepiah]

Fixes #2714

Hello @lonvia , I have nominatim installed

please I made a few changes to nominatim , but I don't know how to view the effect of the change. May be I am not compiling nominatim correctly. please what are the steps to take after making changes.

[mtmail]

Add BDD tests first https://github.com/osm-search/Nominatim/blob/master/docs/develop/Testing.md

The github issue asked "Note: if you want to pick this up as a 'good first issue', please start with creating a BDD test that reproduces the example from the issue and create a PR with the test (which should still be failing at this point). Start with the following test as a blueprint: [...]"

Later you won't need to install Nominatim. It comes with a nominatim-cli.py script which run the code in the /src directory directly. https://github.com/osm-search/Nominatim/blob/master/docs/develop/Development-Environment.md That'll allow you to create a new database, import data and run searches against the imported data.

[lonvia]

#3687 has added a test for this. The test has moved to

Nominatim/test/bdd/features/db/import/linking.feature

Lines 315 to 316 in 478a874

	@skip
	Scenario: Linked places expand default language names

Remove the @skip and run the test to see if it is successful. You can run just the one test with pytest test/bdd/test_db.py -k linked_places_expand_default_language_names.

[tarhsandrasepiah]

please i get psycopg.errors.UndefinedFunction: function placex_insert() does not exist after running the test.

please how may I go about it.