make ort jdk java options configurable#49
Conversation
Signed-off-by: Benn Otieno <benn.otieno@aleph-alpha.com>
bennotieno
force-pushed
the
override-ort-jdk-options
branch
from
269a7c7 to
4c1df3a
Compare
tsteenbe
left a comment
tsteenbe
left a comment
There was a problem hiding this comment.
@bennotieno FYI I am working on overhaul of this action based on my recent work on Forgejo Action for ORT - introducing a new mode without Docker and adding a lot more tests
action.yml
Outdated
| Project version number or release name (use the version from package metadata, not VCS revision). | ||
| By default, the Git short SHA is used. | ||
| required: false | ||
| ort-jdk-java-options: |
There was a problem hiding this comment.
@bennotieno The parameters are sorted alphabetically, would you mind moving this up.
Signed-off-by: Benn Otieno <benn.otieno@aleph-alpha.com>
Hi @tsteenbe, nice to know, so what's the plan with this action? Will it be archived in favour of the Forgejo Action? |
|
2 participants
At the moment the java jdk options are hardcoded to
-Xmx5120m. This change makes that configuration flexible and allows for some performance tuning. It will default to-Xmx5120mas previously set.Please ensure that your pull request adheres to our contribution guidelines. Thank you!