-
Notifications
You must be signed in to change notification settings - Fork 3
feat/fix!: only support ESLint v9 and make fixes #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…uxt-fontawesome because they require too much effort to port to ESLint v9
…igArray.getConfig
|
Please see #350 for some relevant discussion.
Also contains two fixes:
settingsfrom the config array. Previously, when using an array configuration,settingswould silently not get picked up.parser. Previously, it only expected a string(path), whereas ESLint 9 expects an object.There is an alternative to loading the config by monkey-patching, eslint/eslint#16806. So, we can make the processors accept
globalsandignoreRulesby wrapping them in a factory function. However, processors use the parser, which depends onparserOptions. So, we would either have to apply the same to parsers, or duplicateparserOptionsdefinitions. We can likely export a helper function to compose the configuration and handle this accordingly, but it might be too much effort for something that's not mandatory right now. But, I wanted to document my thoughts and findings here.