Skip to content

Conversation

@yusufkandemir
Copy link

Please see #350 for some relevant discussion.

Also contains two fixes:

  • Properly get settings from the config array. Previously, when using an array configuration, settings would silently not get picked up.
  • Correctly load parser. Previously, it only expected a string(path), whereas ESLint 9 expects an object.

There is an alternative to loading the config by monkey-patching, eslint/eslint#16806. So, we can make the processors accept globals and ignoreRules by wrapping them in a factory function. However, processors use the parser, which depends on parserOptions. So, we would either have to apply the same to parsers, or duplicate parserOptions definitions. We can likely export a helper function to compose the configuration and handle this accordingly, but it might be too much effort for something that's not mandatory right now. But, I wanted to document my thoughts and findings here.

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2025

⚠️ No Changeset found

Latest commit: 8bdea26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant