fix-double-free #485 #669
Open
fix-double-free #485 #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralwing
force-pushed
the
fix-double-free
branch
2 times, most recently
from
a23aa16 to
4aa6a52
Compare
This was referenced Sep 1, 2025
ralwing
force-pushed
the
fix-double-free
branch
from
4aa6a52 to
193a500
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a potential double-free issue by replacing C-style extern variable declarations with getter functions that return references to static variables. This change improves encapsulation and prevents potential memory management issues.
- Replace extern variable declarations with getter function declarations in the header
- Convert extern variable definitions to static variables with corresponding getter functions
- Update callers to use getter functions instead of direct variable access
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ouster_client/include/ouster/types.h | Updates header declarations to use getter functions instead of extern variables |
| ouster_client/src/sensor_info.cpp | Implements static variables with getter functions and updates usage sites |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Samahu
approved these changes
Sep 3, 2025
Co-authored-by: Ussama Naal <606033+Samahu@users.noreply.github.com>
This was referenced Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues & PRs
ouster-lidar/ouster-ros#485
Summary of Changes
This change replaces C like extern variable linkage with getter function
Validation
Build and tests.
Related to ouster-lidar/ouster-ros#486