perf(cache): remove package.json index arena indirection#1003
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1003 +/- ##
==========================================
- Coverage 94.08% 94.06% -0.03%
==========================================
Files 18 18
Lines 3416 3404 -12
==========================================
- Hits 3214 3202 -12
Misses 202 202 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d64f875 to
c4d372f
Compare
Merging this PR will improve performance by 4.88%
Performance Changes
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PackageJsonIndexindirection in cached pathsOption<Arc<PackageJson>>directly inCachedPath::package_jsonpackage_jsonsarena (RwLock<Vec<Arc<PackageJson>>>)find_package_jsonto return cached package json directlyMotivation
This removes one lookup/lock layer from package.json resolution hot paths while preserving behavior.
Testing
just ready