ci(benchmarks): Update formatter fixtures

[leaysgur]

Fixes #15628

• Remove unused TestFiles::react()
• Refactor private function to be inlined
• Add formatter fixtures
• Expand timeout 5 > 10s

[leaysgur]

• ci(benchmarks): Update formatter fixtures #15658 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR updates the formatter benchmark fixtures by introducing a dedicated formatter() method with a curated set of test files spanning various sizes and file types, and refactors existing test file methods for consistency.

• Adds a new formatter() method with 9 test files ranging from small (2.46KB) to extra large (346KB) covering JSX, TS, TSX, and JS files
• Updates the formatter benchmark to use the new dedicated formatter() fixtures instead of minimal()
• Refactors complicated() method to inline the URL array, improving code consistency

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
tasks/common/src/test_file.rs	Removes unused react() method, adds new formatter() method with diverse test files, and refactors complicated() for consistency
tasks/benchmark/benches/formatter.rs	Updates formatter benchmark to use TestFiles::formatter() instead of minimal()

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging #15658 will not alter performance

_{Comparing 11-13-ci_benchmarks_update_formatter_fixtures (9a9eba7) with main (ba76081)¹}

Summary

✅ 34 untouched
🆕 8 new
⏩ 3 skipped²

Benchmarks breakdown

	Mode	Benchmark	BASE	HEAD	Change
🆕	Simulation	formatter[App.tsx]	N/A	56.6 ms	N/A
🆕	Simulation	formatter[Search.tsx]	N/A	2.1 ms	N/A
🆕	Simulation	formatter[core.js]	N/A	2.4 ms	N/A
🆕	Simulation	formatter[errors.ts]	N/A	850.2 µs	N/A
🆕	Simulation	formatter[handle-comments.js]	N/A	3.9 ms	N/A
🆕	Simulation	formatter[index.tsx]	N/A	5.2 ms	N/A
🆕	Simulation	formatter[next.ts]	N/A	3.2 ms	N/A
🆕	Simulation	formatter[types.ts]	N/A	15 ms	N/A

Footnotes

1. No successful run was found on main (7b29f21) during the generation of this report, so ba76081 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Dunqing]

I am fine with changing benchmark files, but adding more formatter benchmark files will cause CI to be a bit slow. What do you think? @Boshen

[leaysgur]

I'll merge it for now.

After that, I'll compare the execution times with the original benchmark.
If it's clearly slower, I'll start deleting files that produce similar results.

[leaysgur]

Merge activity

• Nov 18, 1:30 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Nov 18, 1:30 AM UTC: leaysgur added this pull request to the Graphite merge queue.
• Nov 18, 1:36 AM UTC: Merged by the Graphite merge queue.

[leaysgur]

NOTE: Since stopped downloading huge files, it actually feels a bit faster...