fix(parser): reject `import something 'source'` #15746

sapphi-red · 2025-11-16T10:04:29Z

import something 'source'

was not rejected but this should be rejected.
https://tc39.es/ecma262/2025/multipage/ecmascript-language-scripts-and-modules.html#prod-ImportDeclaration

sapphi-red · 2025-11-16T10:04:44Z

fix(parser): reject import something 'source' #15746 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR fixes a parser bug where invalid import syntax import something 'source' (missing the from keyword) was incorrectly accepted. According to the ECMAScript specification, import declarations must include the from keyword between the import specifier and the module source string.

Key changes:

Added validation to reject import statements with a default specifier followed directly by a string literal without the from keyword
Added comprehensive test coverage for various invalid import patterns
Updated snapshot file to reflect the new expected error messages

Reviewed Changes

Copilot reviewed 1 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/oxc_parser/src/js/module.rs	Added check to reject `import something 'source'` syntax by expecting `from` keyword when default specifier is followed by a string
tasks/coverage/misc/pass/import-from-from.js	Test case verifying valid edge case `import from from 'module'` where `from` is used as an identifier
tasks/coverage/misc/fail/import-without-from.js	Test case for invalid `import unknown 'module'` syntax
tasks/coverage/misc/fail/import-type-without-from.ts	Test case for invalid `import type 'module'` syntax
tasks/coverage/misc/fail/import-source-without-from.js	Test case for invalid `import source 'module'` syntax
tasks/coverage/misc/fail/import-from-str.js	Test case for invalid `import from 'module'` syntax
tasks/coverage/misc/fail/import-defer-without-from.js	Test case for invalid `import defer 'module'` syntax
tasks/coverage/snapshots/parser_misc.snap	Updated snapshot with expected error messages for all new failing test cases

##Icopilot Suggestions

No issues found

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codspeed-hq · 2025-11-16T10:10:01Z

CodSpeed Performance Report

Merging #15746 will not alter performance

_{Comparing 11-16-fix_parser_reject_import_something_source_ (671f3cb) with main (9f54a36)¹}

Summary

✅ 37 untouched

No successful run was found on main (a7ce782) during the generation of this report, so 9f54a36 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

leaysgur · 2025-11-16T10:18:25Z

@sapphi-red .snap file missing for anything other than the parser? CI is failing. 👀

sapphi-red · 2025-11-16T15:56:50Z

Oops, my bad, I forgot to run them. I've updated them now.

Boshen · 2025-11-17T02:58:30Z

Merge activity

Nov 17, 2:58 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 17, 2:58 AM UTC: Boshen added this pull request to the Graphite merge queue.
Nov 17, 3:04 AM UTC: Merged by the Graphite merge queue.

```js import something 'source' ``` was not rejected but this should be rejected. https://tc39.es/ecma262/2025/multipage/ecmascript-language-scripts-and-modules.html#prod-ImportDeclaration

### 💥 BREAKING CHANGES - ea51b0b napi: [**BREAKING**] Standardize function naming with sync suffixes (#15661) (Boshen) ### 🚀 Features - 77efb76 parser: Improve error message for invalid switch clauses (#15728) (sapphi-red) - 5691727 parser: Improve `import source` `from` error message (#15727) (sapphi-red) - b7404bc parser: Improve error message for missing function body (#15726) (sapphi-red) - 71c2fb0 parser: Improve error message when JSX is found while not enabled (#15725) (sapphi-red) - 56e7e44 minifier: Disable removal of unnecessary `use strict` directives for DCE (#15691) (sapphi-red) - 8a61cfd allocator, ast: Introduce `UnstableAddress` trait (#15700) (overlookmotel) - f5ce55a napi: Export all options using wildcard exports (Boshen) - 68703b9 minifier: Rotate binary expressions to remove parentheses (#15473) (sapphi-red) ### 🐛 Bug Fixes - c023ba6 semantic: Do not duplicate statements in temp `Vec` when binding `TSModuleDeclaration`s (#15724) (overlookmotel) - d60ca81 parser: Reject `import something 'source'` (#15746) (sapphi-red) - e0728fa ast: Exclude comment end position from `is_inside_comment` check (#15753) (camc314) - 9f54a36 semantic: Error on `\00` in strict mode (#15743) (sapphi-red) - 440a977 ast: Include rest properties when using `get_binding_identifiers` (#15710) (camc314) ### ⚡ Performance - 1f09d3c parser: Faster checking for invalid modifiers (#15717) (overlookmotel) - d8d4e31 ast: Use loop instead of recursion in `TSModuleDeclarationBody::as_module_block_mut` (#15713) (overlookmotel) ### 📚 Documentation - e033d50 ast: Clarify behavior of `TSModuleDeclaration::has_use_strict_directive` (#15730) (overlookmotel) - 9eda70f allocator: Improve docs for `Address` methods (#15697) (overlookmotel)

github-actions bot added A-parser Area - Parser C-bug Category - Bug labels Nov 16, 2025

sapphi-red marked this pull request as ready for review November 16, 2025 10:07

Copilot AI review requested due to automatic review settings November 16, 2025 10:07

sapphi-red assigned Boshen Nov 16, 2025

sapphi-red requested a review from Boshen November 16, 2025 10:07

Copilot started reviewing on behalf of sapphi-red November 16, 2025 10:07 View session

Copilot finished reviewing on behalf of sapphi-red November 16, 2025 10:08

Copilot AI reviewed Nov 16, 2025

View reviewed changes

sapphi-red force-pushed the 11-16-fix_parser_reject_import_something_source_ branch from ff9bfc2 to 671f3cb Compare November 16, 2025 15:56

Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 17, 2025

fix(parser): reject import something 'source' (#15746)

d60ca81

```js import something 'source' ``` was not rejected but this should be rejected. https://tc39.es/ecma262/2025/multipage/ecmascript-language-scripts-and-modules.html#prod-ImportDeclaration

graphite-app bot force-pushed the 11-16-fix_parser_reject_import_something_source_ branch from 671f3cb to d60ca81 Compare November 17, 2025 02:58

graphite-app bot merged commit d60ca81 into main Nov 17, 2025
21 checks passed

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 17, 2025

graphite-app bot deleted the 11-16-fix_parser_reject_import_something_source_ branch November 17, 2025 03:04

Boshen mentioned this pull request Nov 17, 2025

release(crates): oxc v0.98.0 #15771

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(parser): reject `import something 'source'` #15746

fix(parser): reject `import something 'source'` #15746

Uh oh!

sapphi-red commented Nov 16, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Nov 16, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

codspeed-hq bot commented Nov 16, 2025 •

edited

Loading

Uh oh!

leaysgur commented Nov 16, 2025

Uh oh!

sapphi-red commented Nov 16, 2025

Uh oh!

Boshen commented Nov 17, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

fix(parser): reject import something 'source' #15746

fix(parser): reject import something 'source' #15746

Uh oh!

Conversation

sapphi-red commented Nov 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Nov 16, 2025

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

codspeed-hq bot commented Nov 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #15746 will not alter performance

Summary

Footnotes

Uh oh!

leaysgur commented Nov 16, 2025

Uh oh!

sapphi-red commented Nov 16, 2025

Uh oh!

Boshen commented Nov 17, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix(parser): reject `import something 'source'` #15746

fix(parser): reject `import something 'source'` #15746

sapphi-red commented Nov 16, 2025 •

edited

Loading

codspeed-hq bot commented Nov 16, 2025 •

edited

Loading

Boshen commented Nov 17, 2025 •

edited by graphite-app bot

Loading