chore(deps): update typescript-go digest to 865ec14 (#259)

Coming soon: The Renovate bot (GitHub App) will be renamed to Mend. PRs
from Renovate will soon appear from 'Mend'. Learn more
[here](https://redirect.github.com/renovatebot/renovate/discussions/37842).

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| typescript-go | digest | `1ca5a2d` -> `865ec14` |

---

📅 **Schedule**: Branch creation - "before 9am" in timezone
Asia/Shanghai, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/oxc-project/tsgolint).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS45Ny4xMCIsInVwZGF0ZWRJblZlciI6IjQxLjk3LjEwIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-actions <github-actions[bot]@users.noreply.github.com>

Author: 2 people

cmd/tsgolint/headless.go

@@ -354,7 +354,7 @@ func runHeadless(args []string) int {
 				rules[i] = linter.ConfiguredRule{
 					Name: r.Name,
 					Run: func(ctx rule.RuleContext) rule.RuleListeners {
-						return r.Run(ctx, nil)
+						return r.Run(ctx, headlessRule.Options)
 					},
 				}
 			}

cmd/tsgolint/payload.go

@@ -29,7 +29,8 @@ type headlessConfig struct {
 }
 
 type headlessRule struct {
-	Name string `json:"name"`
+	Name    string `json:"name"`
+	Options any    `json:"options,omitempty"`
 }
 
 func deserializePayload(data []byte) (*headlessPayload, error) {

e2e/__snapshots__/snapshot.test.ts.snap

@@ -716,6 +716,34 @@ exports[`TSGoLint E2E Snapshot Tests > should generate consistent diagnostics sn
     },
     "rule": "require-await",
   },
+  {
+    "file_path": "fixtures/basic/rules/no-floating-promises/void.ts",
+    "fixes": [],
+    "message": {
+      "description": "This rule requires the \`strictNullChecks\` compiler option to be turned on to function correctly.",
+      "id": "noStrictNullCheck",
+    },
+    "range": {
+      "end": 0,
+      "pos": 0,
+    },
+    "rule": "no-unnecessary-boolean-literal-compare",
+    "suggestions": [],
+  },
+  {
+    "file_path": "fixtures/basic/rules/no-floating-promises/void.ts",
+    "fixes": [],
+    "message": {
+      "description": "Function has no 'await' expression.",
+      "id": "missingAwait",
+    },
+    "range": {
+      "end": 53,
+      "pos": 0,
+    },
+    "rule": "require-await",
+    "suggestions": [],
+  },
   {
     "file_path": "fixtures/basic/rules/no-for-in-array/index.ts",
     "kind": 0,
@@ -4345,3 +4373,40 @@ exports[`TSGoLint E2E Snapshot Tests > should handle tsconfig diagnostics when T
   },
 ]
 `;
+
+exports[`TSGoLint E2E Snapshot Tests > supports passing rule config 1`] = `
+[
+  {
+    "file_path": "fixtures/basic/rules/no-floating-promises/void.ts",
+    "fixes": [],
+    "message": {
+      "description": "Promises must be awaited.",
+      "help": "The promise must end with a call to .catch, or end with a call to .then with a rejection handler.",
+      "id": "floating",
+    },
+    "range": {
+      "end": 76,
+      "pos": 54,
+    },
+    "rule": "no-floating-promises",
+    "suggestions": [
+      {
+        "fixes": [
+          {
+            "range": {
+              "end": 58,
+              "pos": 54,
+            },
+            "text": "await",
+          },
+        ],
+        "message": {
+          "description": "Promises must be awaited.",
+          "help": "The promise must end with a call to .catch, or end with a call to .then with a rejection handler.",
+          "id": "floating",
+        },
+      },
+    ],
+  },
+]
+`;

e2e/fixtures/basic/rules/no-floating-promises/void.ts

@@ -0,0 +1,4 @@
+async function returnsPromise() {
+  return 'value';
+}
+void returnsPromise();

e2e/snapshot.test.ts

@@ -176,6 +176,10 @@ async function getTestFiles(testPath: string): Promise<string[]> {
   return allFiles;
 }
 
+function resolveTestFilePath(relativePath: string): string {
+  return join(FIXTURES_DIR, relativePath);
+}
+
 function generateConfig(files: string[], rules: readonly (typeof ALL_RULES)[number][] = ALL_RULES): string {
   // Headless payload format:
   // ```json
@@ -225,6 +229,43 @@ describe('TSGoLint E2E Snapshot Tests', () => {
     expect(diagnostics).toMatchSnapshot();
   });
 
+  it('supports passing rule config', async () => {
+    const testFile = resolveTestFilePath('basic/rules/no-floating-promises/void.ts');
+    const config = (ignoreVoid: boolean) => ({
+      version: 2,
+      configs: [
+        {
+          file_paths: [testFile],
+          rules: [
+            {
+              name: 'no-floating-promises',
+              options: { ignoreVoid },
+            },
+          ],
+        },
+      ],
+    });
+
+    let output: Buffer;
+    output = execFileSync(TSGOLINT_BIN, ['headless'], {
+      input: JSON.stringify(config(false)),
+    });
+
+    let diagnostics = parseHeadlessOutput(output);
+    diagnostics = sortDiagnostics(diagnostics);
+
+    expect(diagnostics.length).toBeGreaterThan(0);
+    expect(diagnostics).toMatchSnapshot();
+
+    // Re-run with ignoreVoid=true, should have no diagnostics
+    output = execFileSync(TSGOLINT_BIN, ['headless'], {
+      input: JSON.stringify(config(true)),
+    });
+
+    diagnostics = parseHeadlessOutput(output);
+    expect(diagnostics.length).toBe(0);
+  });
+
   it.runIf(process.platform === 'win32')(
     'should not panic with mixed forward/backslash paths from Rust (issue #143)',
     async () => {

internal/rules/no_floating_promises/no_floating_promises.go

@@ -1,22 +1,24 @@
 package no_floating_promises
 
 import (
+	"encoding/json"
+
 	"github.com/microsoft/typescript-go/shim/ast"
 	"github.com/microsoft/typescript-go/shim/checker"
 	"github.com/microsoft/typescript-go/shim/scanner"
 	"github.com/typescript-eslint/tsgolint/internal/rule"
 	"github.com/typescript-eslint/tsgolint/internal/utils"
 )
 
-type NoFloatingPromisesOptions struct {
-	AllowForKnownSafeCalls          []utils.TypeOrValueSpecifier
-	AllowForKnownSafeCallsInline    []string
-	AllowForKnownSafePromises       []utils.TypeOrValueSpecifier
-	AllowForKnownSafePromisesInline []string
-	CheckThenables                  *bool
-	IgnoreIIFE                      *bool
-	IgnoreVoid                      *bool
-}
+// type NoFloatingPromisesOptions struct {
+// 	AllowForKnownSafeCalls          []utils.TypeOrValueSpecifier
+// 	AllowForKnownSafeCallsInline    []string
+// 	AllowForKnownSafePromises       []utils.TypeOrValueSpecifier
+// 	AllowForKnownSafePromisesInline []string
+// 	CheckThenables                  *bool
+// 	IgnoreIIFE                      *bool
+// 	IgnoreVoid                      *bool
+// }
 
 var messageBase = "Promises must be awaited."
 
@@ -87,23 +89,19 @@ func buildFloatingVoidMessage() rule.RuleMessage {
 var NoFloatingPromisesRule = rule.Rule{
 	Name: "no-floating-promises",
 	Run: func(ctx rule.RuleContext, options any) rule.RuleListeners {
-		opts, ok := options.(NoFloatingPromisesOptions)
-		if !ok {
-			opts = NoFloatingPromisesOptions{
-				AllowForKnownSafeCalls:          []utils.TypeOrValueSpecifier{},
-				AllowForKnownSafeCallsInline:    []string{},
-				AllowForKnownSafePromises:       []utils.TypeOrValueSpecifier{},
-				AllowForKnownSafePromisesInline: []string{},
+		// If we already have options of the correct type, use them directly.
+		var opts NoFloatingPromisesOptions
+		if castOpts, ok := options.(NoFloatingPromisesOptions); ok {
+			opts = castOpts
+		} else {
+			// Otherwise, attempt to unmarshal from JSON.
+			optsBytes, err := json.Marshal(options)
+			if err != nil {
+				panic("NoFloatingPromisesRule: failed to marshal options: " + err.Error())
+			}
+			if err := json.Unmarshal(optsBytes, &opts); err != nil {
+				panic("NoFloatingPromisesRule: failed to unmarshal options: " + err.Error())
 			}
-		}
-		if opts.CheckThenables == nil {
-			opts.CheckThenables = utils.Ref(false)
-		}
-		if opts.IgnoreIIFE == nil {
-			opts.IgnoreIIFE = utils.Ref(false)
-		}
-		if opts.IgnoreVoid == nil {
-			opts.IgnoreVoid = utils.Ref(true)
 		}
 
 		isHigherPrecedenceThanUnary := func(node *ast.Node) bool {
@@ -163,10 +161,9 @@ var NoFloatingPromisesRule = rule.Rule{
 			}
 
 			// The highest priority is to allow anything allowlisted
-			if utils.TypeMatchesSomeSpecifier(
+			if utils.TypeMatchesSomeSpecifierInterface(
 				t,
 				opts.AllowForKnownSafePromises,
-				opts.AllowForKnownSafePromisesInline,
 				ctx.Program,
 			) {
 				return false
@@ -181,7 +178,7 @@ var NoFloatingPromisesRule = rule.Rule{
 			}
 
 			// ...and only check all Thenables if explicitly told to
-			if !*opts.CheckThenables {
+			if !opts.CheckThenables {
 				return false
 			}
 
@@ -237,10 +234,9 @@ var NoFloatingPromisesRule = rule.Rule{
 
 			t := ctx.TypeChecker.GetTypeAtLocation(node.AsCallExpression().Expression)
 
-			return utils.TypeMatchesSomeSpecifier(
+			return utils.TypeMatchesSomeSpecifierInterface(
 				t,
 				opts.AllowForKnownSafeCalls,
-				opts.AllowForKnownSafeCallsInline,
 				ctx.Program,
 			)
 		}
@@ -290,7 +286,7 @@ var NoFloatingPromisesRule = rule.Rule{
 				return isUnhandledPromise(expr.Right)
 			}
 
-			if !*opts.IgnoreVoid && ast.IsVoidExpression(node) {
+			if !opts.IgnoreVoid && ast.IsVoidExpression(node) {
 				// Similarly, a `void` expression always returns undefined, so we need to
 				// see what's inside it without checking the type of the overall expression.
 				return isUnhandledPromise(node.Expression())
@@ -379,7 +375,7 @@ var NoFloatingPromisesRule = rule.Rule{
 			ast.KindExpressionStatement: func(node *ast.Node) {
 				exprStatement := node.AsExpressionStatement()
 
-				if *opts.IgnoreIIFE && isAsyncIife(exprStatement) {
+				if opts.IgnoreIIFE && isAsyncIife(exprStatement) {
 					return
 				}
 
@@ -396,13 +392,13 @@ var NoFloatingPromisesRule = rule.Rule{
 				}
 				if promiseArray {
 					var msg rule.RuleMessage
-					if *opts.IgnoreVoid {
+					if opts.IgnoreVoid {
 						msg = buildFloatingPromiseArrayVoidMessage()
 					} else {
 						msg = buildFloatingPromiseArrayMessage()
 					}
 					ctx.ReportNode(node, msg)
-				} else if *opts.IgnoreVoid {
+				} else if opts.IgnoreVoid {
 					var msg rule.RuleMessage
 					if nonFunctionHandler {
 						msg = buildFloatingUselessRejectionHandlerVoidMessage()