feat: add options schema for no-base-to-string and no-confusing-void-expression
#392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd the label 0-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camchenry
changed the title
no-base-to-stringno-base-to-string and no-confusing-void-expression
graphite-app
bot
changed the base branch from
11-10-docs_update_docs_for_adding_new_rule_and_options_schema
to
graphite-base/392
graphite-app
bot
force-pushed
the
graphite-base/392
branch
from
68f98ec to
85c011f
Compare
graphite-app
bot
force-pushed
the
11-10-feat_add_options_schema_for_no-base-to-string_
branch
from
679fba3 to
3767e34
Compare
graphite-app
bot
force-pushed
the
11-10-feat_add_options_schema_for_no-base-to-string_
branch
from
3767e34 to
6b6e8cf
Compare
Member
Author
Merge activity
|
…id-expression` (#392) Admittedly, I meant to split this into two PRs but accidentally put it in one, and I don't feel like splitting it back so we're just gonna roll with it.
graphite-app
bot
force-pushed
the
11-10-feat_add_options_schema_for_no-base-to-string_
branch
from
6b6e8cf to
e366eaf
Compare
graphite-app
bot
deleted the
11-10-feat_add_options_schema_for_no-base-to-string_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admittedly, I meant to split this into two PRs but accidentally put it in one, and I don't feel like splitting it back so we're just gonna roll with it.