Skip to content

feat: add options schema for no-base-to-string and no-confusing-void-expression #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Nov 11, 2025
Merged

feat: add options schema for no-base-to-string and no-confusing-void-expression #392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions internal/rules/no_base_to_string/no_base_to_string.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@ func buildBaseToStringMessage(name string, certainty usefulness) rule.RuleMessag
}
}

type NoBaseToStringOptions struct {
IgnoredTypeNames []string
}

type usefulness uint32

const (
Expand All @@ -51,12 +47,7 @@ const (
var NoBaseToStringRule = rule.Rule{
Name: "no-base-to-string",
Run: func(ctx rule.RuleContext, options any) rule.RuleListeners {
opts, ok := options.(NoBaseToStringOptions)
if !ok {
opts = NoBaseToStringOptions{
IgnoredTypeNames: []string{"Error", "RegExp", "URL", "URLSearchParams"},
}
}
opts := utils.UnmarshalOptions[NoBaseToStringOptions](options, "no-base-to-string")

var collectToStringCertainty func(
t *checker.Type,
Expand Down
33 changes: 33 additions & 0 deletions internal/rules/no_base_to_string/options.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions internal/rules/no_base_to_string/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"$schema": "https://json-schema.org/draft-07/schema#",
"definitions": {
"no_base_to_string_options": {
"type": "object",
"properties": {
"ignoredTypeNames": {
"type": "array",
"items": {
"type": "string"
},
"default": ["Error", "RegExp", "URL", "URLSearchParams"]
}
}
}
}
}
11 changes: 1 addition & 10 deletions internal/rules/no_confusing_void_expression/no_confusing_void_expression.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,19 +57,10 @@ func buildVoidExprWrapVoidMessage() rule.RuleMessage {
}
}

type NoConfusingVoidExpressionOptions struct {
IgnoreArrowShorthand bool
IgnoreVoidOperator bool
IgnoreVoidReturningFunctions bool
}

var NoConfusingVoidExpressionRule = rule.Rule{
Name: "no-confusing-void-expression",
Run: func(ctx rule.RuleContext, options any) rule.RuleListeners {
opts, ok := options.(NoConfusingVoidExpressionOptions)
if !ok {
opts = NoConfusingVoidExpressionOptions{}
}
opts := utils.UnmarshalOptions[NoConfusingVoidExpressionOptions](options, "no-confusing-void-expression")

canFix := func(node *ast.Node) bool {
t := utils.GetConstrainedTypeAtLocation(ctx.TypeChecker, node)
Expand Down
Loading