fix(Gradle): Update methods on GradleProviderInfo to support calling hasPactsFromPactBroker without options #1586

Author: uglyog

build.gradle

@@ -146,8 +146,10 @@ subprojects {
     publications {
       mavenPublication(MavenPublication) {
         from components.java
-        artifact sourceJar
-        artifact javadocJar
+        if (!project.hasProperty('isGradleRelease')) {
+          artifact sourceJar
+          artifact javadocJar
+        }
         pom {
           name = project.name
           description = StringEscapeUtils.escapeXml11(new File(projectDir, 'README.md').text)

provider/gradle/README.md

@@ -693,11 +693,7 @@ pact {
 }
 ```
 
-**NOTE: Currently the pacts are fetched from the broker during the configuration phase of the build. This means that
-if the broker is not available, you will not be able to run any Gradle tasks.** This should be fixed in a forth coming
-release.
-
-In the mean time, to only load the pacts when running the validate task, you can do something like:
+To only load the pacts when running the validate task, you can do something like:
 
 ```groovy
 pact {

provider/gradle/src/main/kotlin/au/com/dius/pact/provider/gradle/GradleProviderInfo.kt

@@ -85,8 +85,9 @@ open class GradleProviderInfo(override var name: String, val project: Project) :
     return fromPactBroker
   }
 
+  @JvmOverloads
   @Deprecated(message = "hasPactsFromPactBroker has been deprecated in favor of fromPactBroker")
-  fun hasPactsFromPactBroker(options: Map<String, Any>, pactBrokerUrl: String): List<ConsumerInfo> {
+  fun hasPactsFromPactBroker(options: Map<String, Any> = mapOf(), pactBrokerUrl: String): List<ConsumerInfo> {
     return try {
       provider.hasPactsFromPactBroker(options, pactBrokerUrl)
     } catch (e: Exception) {
@@ -118,9 +119,10 @@ open class GradleProviderInfo(override var name: String, val project: Project) :
     return fromPactBroker
   }
 
+  @JvmOverloads
   @Deprecated(message = "hasPactsFromPactBroker has been deprecated in favor of fromPactBroker")
   fun hasPactsFromPactBrokerWithSelectors(
-    options: Map<String, Any?>,
+    options: Map<String, Any?> = mapOf(),
     pactBrokerUrl: String,
     selectors: List<ConsumerVersionSelector>
   ): List<ConsumerInfo> {
@@ -177,7 +179,7 @@ open class GradleProviderInfo(override var name: String, val project: Project) :
         |For instance:
         |
         |fromPactBroker {
-        |    selectors = latestTags('test')
+        |    withSelectors { latestTag('test') }
         |    enablePending = true
         |    providerTags = ['master']
         |}