Skip to content

Conversation

LazyAfternoons
Copy link
Contributor

@LazyAfternoons LazyAfternoons commented Jul 31, 2025

Short description

This PR moves a few unused dependencies.

List of changes proposed in this pull request

  • Removes react-native-tab-view and @react-navigation/material-top-tabs which have not been used since we migrated to the new design system;
  • Removes react-native-render-html which was introduced in this PR to render HTML content in the message sections. This caused a missing library htmlparser2 currently used in FIMS (io-app/ts/features/fims/singleSignOn/saga/handleFimsAuthorizationOrImplicitCodeFlow.ts) which was imported through react-native-render-html. This PR adds the 7.2.0 version which is the one currently used according to the yarn.lock to avoid changes not related to this PR;
  • Removes react-native-masked-text which has not been used since we migrated to the new design system. Removes the TextInputMask component and its mock as well;
  • Removes react-native-markdown-display which was introduced in this PR to display markdown content in the FCI flow;
  • Removes react-native-image-pan-zoom and i which was introduce in this PR to zoom on payment receipts. Removes its patch as well.
  • Removes metro-babel-register which is an old React Native dependency and it's not explicitly required anymore;
  • Removes @react-native-community/slider which was introduce in this PR without any reference;
  • Removes js-yaml and @types/js-yaml which were added in this PR to generate locales from .yml files. Currently we don't use them anymore;
  • Removes @tsconfig/react-native which is an old React Native dependency. It should be extended by the tsconfig.json but we don't that;
  • Removes @babel/preset-typescript same as above but with babel.config.json. This change broke react-native-svg-transformer which we use to render .svg files as React components because the babel transformer path specified in metro.config.js couldn't be found, making Metro crash. This PR updates the library to the latest version as it was quite old and updates the metro.config.js according to the instructions;
  • Removes react-native-bundle-visualizer which is quite outdated as well. It can still be used by running npx react-native-bundle-visualizer.

How to test

Run yarn && cd ios && bundler exec pod install && cd ...
Test critical flows on both Android and iOS, everything should work as expected. Be sure to test the impacted FIMS flow and the SVG files rendering just in case.

Copy link
Contributor

github-actions bot commented Jul 31, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Jul 31, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@LazyAfternoons LazyAfternoons changed the title deps: [IOAPPX-504] Remove unused dependencies chore: [IOAPPX-504] Remove unused dependencies Jul 31, 2025
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.41%. Comparing base (c0408b5) to head (a01f2bd).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7245   +/-   ##
=======================================
  Coverage   59.41%   59.41%           
=======================================
  Files        1771     1771           
  Lines       37639    37639           
  Branches     8588     8540   -48     
=======================================
  Hits        22364    22364           
- Misses      15194    15206   +12     
+ Partials       81       69   -12     

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0408b5...a01f2bd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LazyAfternoons LazyAfternoons marked this pull request as ready for review August 1, 2025 09:50
@LazyAfternoons LazyAfternoons self-assigned this Aug 1, 2025
Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the entire B&P flow on both Android and iOS devices.
No regressions or crashes observed🚀
Great cleanup work! 🧹✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants