-
Notifications
You must be signed in to change notification settings - Fork 109
chore: [IOAPPX-504] Remove unused dependencies #7245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7245 +/- ##
=======================================
Coverage 59.41% 59.41%
=======================================
Files 1771 1771
Lines 37639 37639
Branches 8588 8540 -48
=======================================
Hits 22364 22364
- Misses 15194 15206 +12
+ Partials 81 69 -12 see 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the entire B&P flow on both Android and iOS devices.
No regressions or crashes observed🚀
Great cleanup work! 🧹✨
Short description
This PR moves a few unused dependencies.
List of changes proposed in this pull request
react-native-tab-view
and@react-navigation/material-top-tabs
which have not been used since we migrated to the new design system;react-native-render-html
which was introduced in this PR to render HTML content in the message sections. This caused a missing libraryhtmlparser2
currently used in FIMS (io-app/ts/features/fims/singleSignOn/saga/handleFimsAuthorizationOrImplicitCodeFlow.ts
) which was imported throughreact-native-render-html
. This PR adds the7.2.0
version which is the one currently used according to the yarn.lock to avoid changes not related to this PR;react-native-masked-text
which has not been used since we migrated to the new design system. Removes theTextInputMask
component and its mock as well;react-native-markdown-display
which was introduced in this PR to display markdown content in the FCI flow;react-native-image-pan-zoom
and i which was introduce in this PR to zoom on payment receipts. Removes its patch as well.metro-babel-register
which is an old React Native dependency and it's not explicitly required anymore;@react-native-community/slider
which was introduce in this PR without any reference;js-yaml
and@types/js-yaml
which were added in this PR to generate locales from.yml
files. Currently we don't use them anymore;@tsconfig/react-native
which is an old React Native dependency. It should be extended by thetsconfig.json
but we don't that;@babel/preset-typescript
same as above but withbabel.config.json
. This change brokereact-native-svg-transformer
which we use to render.svg
files as React components because the babel transformer path specified inmetro.config.js
couldn't be found, makingMetro
crash. This PR updates the library to the latest version as it was quite old and updates themetro.config.js
according to the instructions;react-native-bundle-visualizer
which is quite outdated as well. It can still be used by runningnpx react-native-bundle-visualizer
.How to test
Run
yarn && cd ios && bundler exec pod install && cd ..
.Test critical flows on both Android and iOS, everything should work as expected. Be sure to test the impacted FIMS flow and the SVG files rendering just in case.