Skip to content

Conversation

mastro993
Copy link
Contributor

Short description

This PR addresses a bug that prevented the offline mini-app from launching if the initial network requests timed out.

List of changes proposed in this pull request

  • Updated IngressScreen logic to dispatch correct actions on timeouts

How to test

  • Make sure to have an active Wallet Instance with at least one credential
  • With a Proxy (eg.: Proxyman) simulate a network delay of at least 15 seconds
  • Launch the app and make sure the offline mini-app is accessible

Preview

Before After
ScreenRecording_08-04-2025.10-02-46_1.MP4
ScreenRecording_08-04-2025.10-04-06_1.MP4

Copy link
Contributor

github-actions bot commented Aug 4, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Aug 4, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

@mastro993 mastro993 changed the title fix(IT Wallet): [SIW-2826] Show offline wallet when startup's requests timeout fix(IT Wallet): [SIW-2826] Offline mini-app not launching when initial network requests time out Aug 4, 2025
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.31%. Comparing base (4434d00) to head (ecc7833).

Files with missing lines Patch % Lines
ts/features/ingress/screens/IngressScreen.tsx 0.00% 14 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4434d00) and HEAD (ecc7833). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (4434d00) HEAD (ecc7833)
10 2
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #7248       +/-   ##
===========================================
- Coverage   59.09%   29.31%   -29.78%     
===========================================
  Files        1764     1526      -238     
  Lines       37351    32949     -4402     
  Branches     8436     7312     -1124     
===========================================
- Hits        22072     9659    -12413     
- Misses      15212    23268     +8056     
+ Partials       67       22       -45     
Files with missing lines Coverage Δ
ts/features/ingress/screens/IngressScreen.tsx 7.81% <0.00%> (-85.84%) ⬇️

... and 928 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4434d00...ecc7833. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants