Skip to content

Conversation

ale-mazz
Copy link
Contributor

@ale-mazz ale-mazz commented Aug 6, 2025

Short Description

This PR introduces support for two new credentials: Education Degree (education_degree) and Education Enrollment (education_enrollment).

List of Changes Proposed in This Pull Request

  • Credential Support:

    • Added full support for the education_degree and education_enrollment credentials.
  • Core Logic:

    • Enhanced the claims parser to correctly handle the new nested path structure present in these credentials.
    • Extended the claims decoder with a new type to process the educational data.
  • UI Enhancements:

    • Introduced an optional gradient background for the ItwCredentialCard and DigitalVersionBadge.
    • Created the new MultiCredentialBadge component only for multi-level credentials.
  • Testing:

    • Added comprehensive mocks, unit, and integration tests for both education_enrollment (ee) and education_degree (ed) to ensure reliability.

Screenshots

IMAGE 2025-08-07 11:18:59 IMAGE 2025-08-07 11:19:16 IMAGE 2025-08-07 11:19:19

How to Test

Prerequisite: You must have an active L3 wallet.

Follow these steps to verify the changes:

  1. Activate the PRE (pre-production) environment.
  2. Request both the Education Degree and Education Enrollment credentials.
  3. Confirm that the credentials are received, parsed, and displayed correctly in the wallet UI.
  4. (Optional) If you are entitled to these documents in production, you can repeat the verification steps in the PROD environment.

# Conflicts:
#	package.json
#	ts/features/itwallet/common/components/ItwCredentialCard/ItwCredentialCard.tsx
#	ts/features/itwallet/common/utils/itwCredentialUtils.ts
#	ts/features/itwallet/common/utils/itwMocksUtils.ts
#	yarn.lock
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Aug 6, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 62.29508% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.41%. Comparing base (05bf109) to head (4dde93d).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../itwallet/common/components/ItwCredentialClaim.tsx 36.66% 19 Missing ⚠️
...llet/common/components/ItwNestedClaimsListItem.tsx 14.28% 6 Missing ⚠️
...on/components/ItwCredentialCard/CardBackground.tsx 28.57% 4 Missing and 1 partial ⚠️
...mponents/ItwCredentialCard/DigitalVersionBadge.tsx 72.72% 3 Missing ⚠️
...components/ItwCredentialCard/ItwCredentialCard.tsx 57.14% 3 Missing ⚠️
ts/features/itwallet/common/utils/itwTypesUtils.ts 75.00% 2 Missing ⚠️
.../onboarding/screens/WalletCardOnboardingScreen.tsx 86.66% 2 Missing ⚠️
...s/itwallet/playgrounds/components/ItwL3Section.tsx 0.00% 2 Missing ⚠️
.../ItwCredentialCard/ItwCardMultiCredentialBadge.tsx 83.33% 1 Missing ⚠️
...common/components/ItwSkeumorphicCard/CardClaim.tsx 50.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #7259    +/-   ##
========================================
  Coverage   59.41%   59.41%            
========================================
  Files        1773     1777     +4     
  Lines       37761    37874   +113     
  Branches     8632     8665    +33     
========================================
+ Hits        22434    22503    +69     
- Misses      15257    15287    +30     
- Partials       70       84    +14     
Files with missing lines Coverage Δ
...s/features/itwallet/common/utils/itwClaimsUtils.ts 81.39% <100.00%> (+2.40%) ⬆️
...atures/itwallet/common/utils/itwCredentialUtils.ts 85.71% <ø> (ø)
ts/features/itwallet/common/utils/itwMocksUtils.ts 100.00% <ø> (ø)
ts/features/itwallet/common/utils/itwStyleUtils.ts 64.00% <100.00%> (+6.85%) ⬆️
ts/features/itwallet/machine/credential/actors.ts 17.39% <ø> (ø)
...features/itwallet/navigation/ItwStackNavigator.tsx 25.00% <ø> (ø)
ts/features/itwallet/navigation/routes.ts 100.00% <ø> (ø)
...rding/components/ItwOnboardingModuleCredential.tsx 85.18% <100.00%> (-2.32%) ⬇️
...omponents/ItwPresentationCredentialStatusAlert.tsx 69.56% <ø> (ø)
...etails/components/ItwPresentationDetailsHeader.tsx 25.00% <ø> (ø)
... and 12 more

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5c7bd...4dde93d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants