Skip to content

Conversation

ChrisMattew
Copy link
Collaborator

@ChrisMattew ChrisMattew commented Aug 6, 2025

Short description

This PR restricts IT-Wallet features (UI, proximity presentation, etc.) to users who have a PID L3 (1.0) and are included in the whitelist

List of changes proposed in this pull request

  • Upgraded @pagopa/io-react-native-wallet-v2 version
  • Improved itwLifecycleIsITWalletValidSelector to check whether the user is whitelisted
  • Improved the condition that determines whether to show the new mdl credential detail screen

How to test

The only scenario in which IT-Wallet and all its features should be visible is when the user is whitelisted and has a PID obtained via the 1.0 APIs with an assurance_level set to "high" (in short, a PID L3 obtained with CIE + PIN).
In all other cases, we should still display Documents within the IO app.

Important

Regarding the mdl detail view, in order to display the new UI and the CTA to generate the engagement QR Code for proximity presentation, the user must meet the requirements to activate IT-Wallet and, in addition, must have the mdl in the new dc+sd-jwt format.

Note: We're making the assumption based solely on the dc+sd-jwt format because it is the credential used for rendering the detail view. Furthermore, if that format is present, the mso_moc format will also be available, as both are requested together in the new issuance flow.

@ChrisMattew ChrisMattew self-assigned this Aug 6, 2025
Copy link
Contributor

github-actions bot commented Aug 6, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Aug 6, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.37%. Comparing base (ff87be3) to head (fcb2202).

Files with missing lines Patch % Lines
...tails/components/ItwPresentationCredentialCard.tsx 0.00% 4 Missing ⚠️
...etails/components/ItwPresentationDetailsHeader.tsx 0.00% 2 Missing ⚠️
...ls/components/ItwPresentationDetailsScreenBase.tsx 0.00% 2 Missing ⚠️
.../screens/ItwPresentationCredentialDetailScreen.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7260   +/-   ##
=======================================
  Coverage   59.37%   59.37%           
=======================================
  Files        1773     1773           
  Lines       37819    37823    +4     
  Branches     8599     8606    +7     
=======================================
+ Hits        22455    22458    +3     
  Misses      15294    15294           
- Partials       70       71    +1     
Files with missing lines Coverage Δ
.../features/itwallet/common/store/selectors/index.ts 87.80% <ø> (+2.09%) ⬆️
...atures/itwallet/lifecycle/store/selectors/index.ts 93.75% <100.00%> (+0.41%) ⬆️
...etails/components/ItwPresentationDetailsHeader.tsx 23.52% <0.00%> (-1.48%) ⬇️
...ls/components/ItwPresentationDetailsScreenBase.tsx 16.12% <0.00%> (-0.54%) ⬇️
.../screens/ItwPresentationCredentialDetailScreen.tsx 3.38% <0.00%> (-0.06%) ⬇️
...tails/components/ItwPresentationCredentialCard.tsx 19.04% <0.00%> (-0.96%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff87be3...fcb2202. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants