Skip to content

Conversation

mastro993
Copy link
Contributor

Warning

Depends on #7027

Short description

This PR adds tracking for the credentials upgrade flow

List of changes proposed in this pull request

  • Added ITW_CREDENTIAL_START_REISSUING and ITW_CREDENTIAL_REISSUING_FAILED events
  • Added failure tracking in ItwIssuanceEidResultScreen component
  • Added action tracking in itwCredentialIssuanceMachine

How to test

  • Start the credential upgrade flow and mock the failure of the /credential endpoint with a proxy (eg: Proxyman)
  • Make sure that the ITW_CREDENTIAL_REISSUING_FAILED event is being tracked
  • Tap on a credential which failed and start the reissuing
  • Make sure that the ITW_CREDENTIAL_START_REISSUING event is being tracked

mastro993 and others added 30 commits May 19, 2025 15:18
Copy link
Contributor

github-actions bot commented Aug 8, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Aug 8, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

@mastro993 mastro993 changed the title chore(IT Wallet): [SIW-2860] Add credentials upgrade tracking chore(IT Wallet): [SIW-2860] Adds events tracking for credentials upgrade flow Aug 8, 2025
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 51.26050% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.23%. Comparing base (bb257d7) to head (c3f36de).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...et/issuance/screens/ItwIssuanceEidResultScreen.tsx 4.54% 21 Missing ⚠️
ts/features/itwallet/machine/credential/actions.ts 0.00% 9 Missing ⚠️
ts/features/itwallet/machine/eid/actions.ts 0.00% 8 Missing ⚠️
ts/features/itwallet/machine/upgrade/actors.ts 16.66% 5 Missing ⚠️
...allet/discovery/components/ItwPaywallComponent.tsx 72.72% 3 Missing ⚠️
ts/features/itwallet/machine/eid/selectors.ts 50.00% 3 Missing ⚠️
ts/features/itwallet/analytics/index.ts 50.00% 2 Missing ⚠️
...screens/ItwL2IdentificationModeSelectionScreen.tsx 0.00% 1 Missing ⚠️
...screens/ItwIssuanceCredentialTrustIssuerScreen.tsx 0.00% 1 Missing ⚠️
ts/features/itwallet/machine/credential/machine.ts 87.50% 1 Missing ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7268   +/-   ##
=======================================
  Coverage   59.23%   59.23%           
=======================================
  Files        1772     1776    +4     
  Lines       37659    37729   +70     
  Branches     8539     8552   +13     
=======================================
+ Hits        22306    22348   +42     
- Misses      15283    15312   +29     
+ Partials       70       69    -1     
Files with missing lines Coverage Δ
...wallet/common/components/ItwCredentialNotFound.tsx 7.69% <ø> (ø)
...twallet/common/components/ItwWalletReadyBanner.tsx 93.33% <100.00%> (ø)
...discovery/components/ItwDiscoveryInfoComponent.tsx 81.25% <100.00%> (+6.25%) ⬆️
...allet/discovery/screens/ItwDiscoveryInfoScreen.tsx 84.61% <ø> (-4.86%) ⬇️
...t/issuance/screens/ItwIssuanceEidFailureScreen.tsx 5.66% <ø> (ø)
ts/features/itwallet/machine/credential/context.ts 100.00% <ø> (ø)
ts/features/itwallet/machine/credential/guards.ts 18.18% <ø> (+1.51%) ⬆️
ts/features/itwallet/machine/eid/actors.ts 2.04% <ø> (ø)
ts/features/itwallet/machine/eid/context.ts 100.00% <ø> (ø)
ts/features/itwallet/machine/upgrade/actions.ts 100.00% <100.00%> (ø)
... and 19 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0de3492...c3f36de. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants