Skip to content

Conversation

Ladirico
Copy link
Contributor

@Ladirico Ladirico commented Aug 26, 2025

Short description

This PR introduces the handling of the timeout case during the app startup loading.
When the app fails to connect within the expected time, the user is offered the option to access the Wallet in offline mode.
Unlike other offline reasons, this case only displays a banner with a refresh action and does not trigger a bottom sheet.

List of changes proposed in this pull request

  • Added specific handling for OfflineAccessReasonEnum.TIMEOUT.
  • Displayed a banner with refresh action for the timeout scenario.
  • Prevented the bottom sheet from being rendered when the reason is timeout.
  • Updated translations for the new timeout alert messages.

Demo

Local .env. (iOS) Prod .env (Android)
Registrazione.schermo.2025-08-28.alle.10.15.12.mov
android.mov

How to test

  1. Start application
  2. Simulate a startup timeout (use proxyman or your internet connection)
  3. Verify that:
  • A banner is displayed with the correct timeout content and refresh action.
  • No bottom sheet is displayed.
  • The refresh action correctly restarts the app.
  1. Verify that other offline reasons (device_offline, session_expired, session_refresh) still show the banner + bottom sheet as expected.

@Ladirico Ladirico self-assigned this Aug 26, 2025
@Ladirico Ladirico added IT Wallet IO-A&I IO - Autenticazione e Identità copy review needed ✋🏼 🖊️ Awaiting copy review by UX Writers. Don't merge if there is this label. labels Aug 26, 2025
Copy link
Contributor

github-actions bot commented Aug 26, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

github-actions bot commented Aug 26, 2025

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@Ladirico Ladirico changed the title [IOPID-3214] Offline wallet: startup timeout scenario chore: [IOPID-3214] Offline wallet: startup timeout scenario Aug 26, 2025
@Ladirico Ladirico changed the title chore: [IOPID-3214] Offline wallet: startup timeout scenario feat: [IOPID-3214] Offline wallet: startup timeout scenario Aug 26, 2025
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

❌ Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.41%. Comparing base (2a7ff38) to head (4253e7f).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...allet/wallet/components/ItwOfflineAlertWrapper.tsx 0.00% 2 Missing ⚠️
ts/features/ingress/screens/IngressScreen.tsx 90.90% 1 Missing ⚠️
ts/sagas/startup.ts 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7282   +/-   ##
=======================================
  Coverage   59.41%   59.41%           
=======================================
  Files        1773     1773           
  Lines       37757    37771   +14     
  Branches     8628     8586   -42     
=======================================
+ Hits        22432    22442   +10     
- Misses      15244    15259   +15     
+ Partials       81       70   -11     
Files with missing lines Coverage Δ
ts/components/screens/LoadingScreenContent.tsx 93.75% <100.00%> (+1.44%) ⬆️
ts/features/ingress/store/reducer/index.ts 53.84% <ø> (ø)
ts/features/ingress/screens/IngressScreen.tsx 92.85% <90.90%> (-0.80%) ⬇️
ts/sagas/startup.ts 36.81% <50.00%> (+0.14%) ⬆️
...allet/wallet/components/ItwOfflineAlertWrapper.tsx 7.89% <0.00%> (-0.44%) ⬇️

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c84b611...4253e7f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
copy review needed ✋🏼 🖊️ Awaiting copy review by UX Writers. Don't merge if there is this label. IO-A&I IO - Autenticazione e Identità IT Wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant