Fix re-request loop for team reviewers (#306)

Similar to the previous issue for users, if a user left a review on behalf
of a team, but the review did not change the rule state, policy-bot
would immediately re-requst a review from the team, leading to extra
notification noise.

Author: bluekeyes

pull/context.go

@@ -202,6 +202,8 @@ type Review struct {
 	State     ReviewState
 	Body      string
 	SHA       string
+
+	Teams []string
 }
 
 type ReviewerType string

pull/github.go

@@ -983,18 +983,33 @@ type v4PullRequestReview struct {
 	State       string
 	Body        string
 	SubmittedAt time.Time
-	Commit      struct {
+
+	Commit struct {
 		OID string
 	}
+
+	// GitHub currently allows at most 15 review requests, so any review could
+	// not be on behalf of more than 15 teams.
+	OnBehalfOf struct {
+		Nodes []struct {
+			Slug string
+		}
+	} `graphql:"onBehalfOf(first: 15)"`
 }
 
 func (r *v4PullRequestReview) ToReview() *Review {
+	teams := make([]string, len(r.OnBehalfOf.Nodes))
+	for i, n := range r.OnBehalfOf.Nodes {
+		teams[i] = n.Slug
+	}
+
 	return &Review{
 		CreatedAt: r.SubmittedAt,
 		Author:    r.Author.GetV3Login(),
 		State:     ReviewState(strings.ToLower(r.State)),
 		Body:      r.Body,
 		SHA:       r.Commit.OID,
+		Teams:     teams,
 	}
 }
 

server/handler/base.go

@@ -322,6 +322,13 @@ func (b *Base) requestReviews(ctx context.Context, prctx pull.Context, client *g
 				Type: pull.ReviewerUser,
 				Name: r.Author,
 			})
+
+			for _, team := range r.Teams {
+				reviewers = append(reviewers, &pull.Reviewer{
+					Type: pull.ReviewerTeam,
+					Name: team,
+				})
+			}
 		}
 	}