Use this->t instead of t

src/Rector/BestPractice/UseThisTInsteadOfTRector.php

@@ -0,0 +1,80 @@
+<?php
+
+declare(strict_types=1);
+
+namespace DrupalRector\Rector\BestPractice;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Stmt\Class_;
+use Rector\NodeTypeResolver\Node\AttributeKey;
+use Rector\Rector\AbstractRector;
+use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
+use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+
+/**
+ * Replaces t() with $this->t().
+ */
+final class UseThisTInsteadOfTRector extends AbstractRector
+{
+    public function getRuleDefinition(): RuleDefinition
+    {
+        return new RuleDefinition(
+            'Turns static t calls into $this->t.',
+            [
+                new ConfiguredCodeSample(
+                    't("Text");',
+                    '$this->t("Text");',
+                    ['t' => '$this->t']
+                ),
+            ]
+        );
+    }
+
+    /**
+     * @return array<class-string<Node>>
+     */
+    public function getNodeTypes(): array
+    {
+        return [FuncCall::class];
+    }
+
+    /**
+     * @param FuncCall $node
+     */
+    public function refactor(Node $node): ?Node
+    {
+        if (!$this->isName($node, 't')) {
+            return null;
+        }
+
+        // not to refactor here
+        $isVirtual = (bool) $node->name->getAttribute(
+            AttributeKey::VIRTUAL_NODE
+        );
+        if ($isVirtual) {
+            return null;
+        }
+
+        $parentFunction = $this->betterNodeFinder->findParentType($node, Node\Stmt\ClassMethod::class);
+        if (!$parentFunction instanceof Node\Stmt\ClassMethod || $parentFunction->isStatic()) {
+            return null;
+        }
+
+        $class = $this->betterNodeFinder->findParentType($node, Class_::class);
+        if (!$class instanceof Class_) {
+            return null;
+        }
+
+        $className = (string) $this->nodeNameResolver->getName($class);
+        if (method_exists($className, 't')) {
+            return new Node\Expr\MethodCall(
+                new Node\Expr\Variable('this'),
+                't',
+                $node->args
+            );
+        }
+
+        return null;
+    }
+}

tests/src/Rector/BestPractive/UseThisTInsteadOfTRector/UseThisTInsteadOfTRectorTest.php

@@ -0,0 +1,35 @@
+<?php
+
+declare(strict_types=1);
+
+namespace DrupalRector\Rector\BestPractive\UseThisTInsteadOfTRector;
+
+use Iterator;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+class UseThisTInsteadOfTRectorTest extends AbstractRectorTestCase
+{
+    /**
+     * @covers ::refactor
+     *
+     * @dataProvider provideData
+     */
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    /**
+     * @return Iterator<<string>>
+     */
+    public static function provideData(): \Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__.'/fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        // must be implemented
+        return __DIR__.'/config/configured_rule.php';
+    }
+}

tests/src/Rector/BestPractive/UseThisTInsteadOfTRector/config/configured_rule.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use DrupalRector\Tests\Rector\Deprecation\DeprecationBase;
+use Rector\Config\RectorConfig;
+
+return static function (RectorConfig $rectorConfig): void {
+    DeprecationBase::addClass(DrupalRector\Rector\BestPractice\UseThisTInsteadOfTRector::class, $rectorConfig, false);
+};

tests/src/Rector/BestPractive/UseThisTInsteadOfTRector/fixture/fixture.php.inc

@@ -0,0 +1,33 @@
+<?php
+class TestT {
+    public function t($string) {
+        return $string;
+    }
+}
+
+class NoT extends TestT {
+
+    public function doThings() {
+        return t('Hello world');
+    }
+
+}
+
+?>
+-----
+<?php
+class TestT {
+    public function t($string) {
+        return $string;
+    }
+}
+
+class NoT extends TestT {
+
+    public function doThings() {
+        return $this->t('Hello world');
+    }
+
+}
+
+?>