clean: Groupby deprecations #1143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for picking that up.
Yes, we might as well be discouraging its use as soon as we can.
Yes, thanks for picking that up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #xxxx (Replace xxxx with the Github issue number)
Tests added: Please use
assert_type()to assert the type of any return valueaxishas been deprecated from groupby methods (https://github.com/pandas-dev/pandas/pull/57109/files)corrwithhas been deprecated on pandas main - is it OK to already remove it from here, or should that wait until 3.0 actually comes out?grouped
fillnahas been deprecated since 2.2